Fix #1223: Cap search results to 10000

cadasta/config/settings/default.py

@@ -523,3 +523,4 @@
 ES_SCHEME = 'http'
 ES_HOST = 'localhost'
 ES_PORT = '9200'
+ES_MAX_RESULTS = 10000

cadasta/search/tests/test_views_async.py

@@ -163,6 +163,47 @@ def test_post_with_results(self, mock_post, mock_get):
         )
         mock_get.assert_not_called()
 
+    @patch('requests.get')
+    @patch('requests.post')
+    def test_post_with_over_max_results(self, mock_post, mock_get):
+        mock_post.return_value.status_code = 200
+        mock_post.return_value.json.return_value = {
+            'hits': {
+                'total': settings.ES_MAX_RESULTS + 1000,
+                'hits': [{
+                    '_type': 'spatial',
+                    '_source': {
+                        'id': self.su.id,
+                        'type': 'AP',
+                        '@timestamp': 'TIMESTAMP',
+                    },
+                }],
+            },
+        }
+
+        response = self.request(user=self.user, method='POST')
+        expected_html = render_to_string(
+            'search/search_result_item.html',
+            context={'result': {
+                'entity_type': self.su.ui_class_name,
+                'url': self.su.get_absolute_url(),
+                'main_label': "Apartment",
+                'attributes': {},
+            }}
+        )
+        assert response.status_code == 200
+        assert response.content['data'] == [[expected_html]]
+        assert response.content['recordsTotal'] == settings.ES_MAX_RESULTS
+        assert response.content['recordsFiltered'] == settings.ES_MAX_RESULTS
+        assert response.content['draw'] == 40
+        assert response.content['timestamp'] == 'TIMESTAMP'
+        mock_post.assert_called_once_with(
+            self.es_endpoint,
+            data=self.es_body,
+            headers={'content-type': 'application/json'},
+        )
+        mock_get.assert_not_called()
+
     @patch('requests.get')
     @patch('requests.post')
     def test_post_with_no_results(self, mock_post, mock_get):

cadasta/search/tests/test_views_default.py

@@ -1,5 +1,7 @@
 import pytest
 import json
+
+from django.conf import settings
 from django.http import Http404
 from django.test import TestCase
 
@@ -40,6 +42,7 @@ def setup_models(self):
     def setup_template_context(self):
         return {
             'object': self.project,
+            'max_num_results': settings.ES_MAX_RESULTS,
         }
 
     def setup_url_kwargs(self):

cadasta/search/views/async.py

@@ -51,7 +51,8 @@ def post(self, request, *args, **kwargs):
                     'error': 'unavailable',
                 })
 
-            num_hits = raw_results['hits']['total']
+            num_hits = min(raw_results['hits']['total'],
+                           settings.ES_MAX_RESULTS)
             results = raw_results['hits']['hits']
 
             if len(results) == 0:

cadasta/search/views/default.py

@@ -1,3 +1,5 @@
+from django.conf import settings
+
 from core.views.generic import TemplateView
 from core.mixins import LoginPermissionRequiredMixin
 from organization import messages as org_messages
@@ -15,6 +17,7 @@ class Search(LoginPermissionRequiredMixin,
     def get_context_data(self, **kwargs):
         context = super().get_context_data(**kwargs)
         context['object'] = self.get_object()
+        context['max_num_results'] = settings.ES_MAX_RESULTS
         return context
 
     def get_object(self, queryset=None):

cadasta/templates/search/search.html

@@ -32,6 +32,7 @@ <h2>{% trans "Search" %}</h2>
                   <ul>
                     <li>Review your wording, make sure that there aren’t any typos in your search query</li>
                     <li>If no results match your query, try removing some search terms (<kbd>John</kbd>, instead of <kbd>John White</kbd>)</li>
+                    <li>Search results are limited to a maximum of {{ max_num_results }} entries</li>
                   </ul>
                   {% endblocktrans%}
                 </div>