Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrome download for pdf #2755

Merged
merged 9 commits into from
Dec 27, 2024

Conversation

alf-cactus
Copy link
Collaborator

Tested in isolated script
@SolidProgramming If you dont need wkhtml anymore I will delete everything above in the file and rename the file
@SolidProgramming Could you test and tell me if this is what you wanted?
@tpurschke Should I uninstall unzip in cleanup role?

@SolidProgramming
Copy link
Contributor

Tested in isolated script @SolidProgramming If you dont need wkhtml anymore I will delete everything above in the file and rename the file @SolidProgramming Could you test and tell me if this is what you wanted? @tpurschke Should I uninstall unzip in cleanup role?

Deleting wkhtml will be the next step when everything works fine with the new method.

Copy link
Contributor

@tpurschke tpurschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this will probably not work without installing various dependencies via ansible (see https://chatgpt.com/share/676578d8-e750-8007-be60-498a7ea3d173)
@SolidProgramming have you successfully tested this manually?

in regard to @alf-cactus 's question: not really necessary to remove unzip later

@SolidProgramming
Copy link
Contributor

SolidProgramming commented Dec 20, 2024

I guess this will probably not work without installing various dependencies via ansible (see https://chatgpt.com/share/676578d8-e750-8007-be60-498a7ea3d173) @SolidProgramming have you successfully tested this manually?

in regard to @alf-cactus 's question: not really necessary to remove unzip later

Not yet because it doesn't work currently. If that works i'll test with new VMs o check if dependencies are needed.

@alf-cactus
Copy link
Collaborator Author

@SolidProgramming I named the directories as you wanted

@SolidProgramming
Copy link
Contributor

@SolidProgramming I named the directories as you wanted

Thanks. Will try that shortly.

@alf-cactus
Copy link
Collaborator Author

added chrome headless shell, test successful for me, please try @SolidProgramming

@alf-cactus alf-cactus merged commit b0832f6 into CactuseSecurity:develop Dec 27, 2024
1 check passed
@alf-cactus alf-cactus deleted the tmp_chrome_download branch December 27, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants