Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NVIDIA module build #167

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Conversation

ventureoo
Copy link
Member

Similar to ZFS, this allows us to build an NVIDIA driver module already purpose-built for our kernel. This will allow us to save NVIDIA driver users from constant rebuilding of dkms modules, which is often accompanied by a number of errors.

Note that in PKGBUILD, we will probably need to update _nv_ver whenever we update the driver itself, so that there is no mismatch in the versions of modules and nvidia-utils in our repository.

Also, note that I did not test the build together with LLVM+LTO, so this may require additional testing/fixes.

Copy link
Member

@sirlucjan sirlucjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far

@ptr1337
Copy link
Member

ptr1337 commented Sep 4, 2023

Thanks! This seems good.
I would do the next day(s) some locale testing (LTO, THin LTO, together with zfs).

If the testing goes well, we can can build them with 6.5.2 into the repository and could make an announcement in the community, that they test it also.
And over the next months, we will implement it to chwd and the ISO.

Lets see how it goes! :)

@ventureoo ventureoo marked this pull request as ready for review September 4, 2023 21:11
@monarc99
Copy link

monarc99 commented Sep 4, 2023

a question as a user:

when you enable _build_nvidia, do you use "updpkgsums" to update the checksums and change PKGBUILD? Or --skipchecksums?

@ptr1337
Copy link
Member

ptr1337 commented Sep 5, 2023

a question as a user:

when you enable _build_nvidia, do you use "updpkgsums" to update the checksums and change PKGBUILD? Or --skipchecksums?

You can use any. When we build the kernel, we have an environment variable to automatically generate it in our script.
But you can just use --skipchecksums

@ptr1337
Copy link
Member

ptr1337 commented Sep 5, 2023

@ventureoo
Copy link
Member Author

@ptr1337 ptr1337 merged commit 45158d1 into CachyOS:master Sep 5, 2023
@monarc99
Copy link

monarc99 commented Sep 5, 2023

Would it be useful to set _nv_ver=535.104.05 by variable?

e.g.
_nv_ver=${_nv_ver-535.104.05}

@ptr1337
Copy link
Member

ptr1337 commented Sep 5, 2023

Would it be useful to set _nv_ver=535.104.05 by variable?

e.g. _nv_ver=${_nv_ver-535.104.05}

Sure ,we can do this.

@Hebarch
Copy link

Hebarch commented Sep 5, 2023

Is possible to add Vulkan Dev as an option?

E.g.: _build_nvidia_vulkan_dev=${_build_nvidia_vulkan_dev-y}

i suppose that u need to add this driver branch to your repos, right ?

Thanks in advance :-)

@ptr1337
Copy link
Member

ptr1337 commented Sep 5, 2023

Is possible to add Vulkan Dev as an option?

E.g.: _build_nvidia_vulkan_dev=${_build_nvidia_vulkan_dev-y}

i suppose that u need to add this driver branch to your repos, right ?

Thanks in advance :-)

I really think, we should not bloat this to much, since it would also required to change the depend on the nvidia-vulkan-utils.
It shouldn't be to hard, if anyone really wants to use the vulkan driver to change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants