Various sysctl cleanups #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already set by Arch via `/usr/lib/sysctl.d/10-arch.conf` from the `filesystem` package. Signed-off-by: Eric Naim <[email protected]>
According to [Arch Wiki](https://wiki.archlinux.org/title/Sysctl#Increase_the_maximum_connections) this only helps on high-loaded servers. Desktops won't become high-loaded servers ever probably, so on the basis of that knowledge remove this. If increasing this value does indeed has tangible benefits, I can revert this. Signed-off-by: Eric Naim <[email protected]>
1Naim
commented
Oct 24, 2024
There was a problem hiding this comment.
Guess I can't add further snippet reviews so I'll add it here
# This tunable is used to define when dirty data is old enough to be eligible for writeout by the
# kernel flusher threads. It is expressed in 100'ths of a second. Data which has been dirty
# in-memory for longer than this interval will be written out next time a flusher thread wakes up
# (Default is 3000).
#vm.dirty_expire_centisecs = 3000
We are also not setting this.
# Only experimental!
# Let Realtime tasks run as long they need
# sched: RT throttling activated
kernel.sched_rt_runtime_us=-1
I'm skeptical about this, maybe we can set it to a higher predefined value than the default instead?
Shendisx
reviewed
Oct 24, 2024
ventureoo
reviewed
Oct 24, 2024
1Naim
force-pushed
the
chore/sysctl-cleanup
branch
from
de0950d
to
2045833
Compare
We already have this set in the kernel, and having a duplicate here can cause instances when users want to test the default algorithm in another kernel, but will still have BBR set. Signed-off-by: Eric Naim <[email protected]>
Signed-off-by: Eric Naim <[email protected]>
|
This PR seems finished now. @ventureoo when you have the time, it would be nice for this to go through one more review before merging. |
This has always been commented. Even if not, the value set is the same as the kernel default. Unless we want to tweak the value, keeping this here is redundant. Signed-off-by: Eric Naim <[email protected]>
ventureoo
reviewed
Nov 25, 2024
This is the default value. No reason to enforce a default, especially if its in a package where it can be overrided anyway from /etc or from cmdline. Signed-off-by: Eric Naim <[email protected]>
ptr1337
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there seems to be a bit of a redundancy in the settings set here, so I'd like to clean it up a bit. There are also some removals/tweaks to settings that don't make quite sense to me (based on my limited knowledge), so I've opted to removed them in the PR, but I am very open for discussion.