Additional changes to StokesMOST #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bill's source mods were based on a slightly older version of CVMix, so I created a temporary branch from where I believe he started his work and copied his changes in. Then I merged master in, resulting in this version of cvmix_kpp.F90
I created a new CVt2 component to the kpp parameter type, it is set to 2.6 by
default during initialization but users can change it by calling
cvmix_put_kpp('CVt2', new_val)
after calling cvmix_init_kpp()
Noticed an if statement was removed (so code inside block always ran), but the existing code was not unindented
gfortran now compiles with same flags CESM uses when DEBUG=TRUE, except I added -Werror to elevate warnings to errors and then also turned on -Wno-maybe-uninitialized to avoid failing tests because the compiler thinks there's a chance we are accessing uninitialized memory (the one failure caught by this in CI was initializing an allocatable array element-by-element inside a loop: this was a false-positive, as the loop covered all indices)
gustavo-marques
approved these changes
Oct 12, 2024
|
Thanks, @mnlevy1981! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes come from W. Large, though he and @gustavo-marques asked me to make one scalar value user-settable (which is da50e0b)