This repository has been archived by the owner on May 27, 2024. It is now read-only.
Muser Data App #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
1.Add USF license for all files
2. Use PyCharm default code format
3. Add Readme file link for e.g https://github.com/CUTR-at-USF/muser-firebase-export
4.Use python. gitignore for e.g https://github.com/CUTR-at-USF/gtfsrdb/blob/master/.gitignore
5. Remove local paths and set all paths global
6.Remove unused imports and function calls
7.Remove print statements
8.Remove port assignment from main method.
9. Handle exceptions in most of the .py file.
10.Work on threshold for cosine similarities.
11.Add few more comments on all .py files.
|
@AnkitRajSri @pradeepsalunke Not sure why #1 is closed? I left a review there. |
|
Closing this request, as we will be working on the old pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chore: Adding Muser Data App, which includes the AI, ETL, and UI