Skip to content
This repository has been archived by the owner on May 27, 2024. It is now read-only.

WIP - Review changes from https://github.com/Wacken88/HSL-OTP-for-Android #471

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP - Review changes from https://github.com/Wacken88/HSL-OTP-for-Android #471

wants to merge 1 commit into from

Conversation

barbeau
Copy link
Member

@barbeau barbeau commented May 6, 2015

From @Wacken88:

so we implemented some features for exporting all kinds of information or for using Street View from the map. Additionally, there is a proof of concept favorites system and a widget to launch the app from the homescreen. Some parts of our implementation require a slightly higher Android version though. Unfortunately, we have been assigned to a new project now so that we probably will not work on it anymore.

Nevertheless, I put our last dev version to GitHub: https://github.com/Wacken88/HSL-OTP-for-Android ...You can try the application yourself and of course also diff the source code with the official OTP app repo. Our version is based on March 9 if I am not mistaken.

I've pulled the diff of the two projects into this PR so we can review and see if we can merge some of these changes into the main OTP Android project.

Thanks @Wacken88!

@vreixo
Copy link
Contributor

vreixo commented May 6, 2015

Wow, sounds great to see more development on the app! :-)

Let's see if I can find some time to try to correct my changes to see if
that solves the problem.
El 6/5/2015 9:53 p. m., "Sean Barbeau" [email protected] escribió:

From @Wacken88 https://github.com/Wacken88:

so we implemented some features for exporting all kinds of information or
for using Street View from the map. Additionally, there is a proof of
concept favorites system and a widget to launch the app from the
homescreen. Some parts of our implementation require a slightly higher
Android version though. Unfortunately, we have been assigned to a new
project now so that we probably will not work on it anymore.

Nevertheless, I put our last dev version to GitHub:
https://github.com/Wacken88/HSL-OTP-for-Android...You can try the
application yourself and of course also diff the source code with the
official OTP app repo. Our version is based on March 9 if I am not mistaken.

I've pulled the diff of the two projects into this PR so we can review and
see if we can merge some of these changes into the main OTP Android project.

Thanks @Wacken88 https://github.com/Wacken88!

You can view, comment on, or merge this pull request online at:

#471
Commit Summary

File Changes

Patch Links:

https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471.patch

https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471.diff

—
Reply to this email directly or view it on GitHub
#471.

@barbeau barbeau changed the title WIP - Merge changes from https://github.com/Wacken88/HSL-OTP-for-Android WIP - Review changes from https://github.com/Wacken88/HSL-OTP-for-Android May 8, 2015
@kalon33
Copy link
Contributor

kalon33 commented Oct 14, 2015

@Wacken88 @barbeau @vreixo : trying to build the app after merging this pull request, I encounter the following error:

/home/nicolas/packaging/sources/OpenTripPlanner-for-Android/opentripplanner-android/build/intermediates/manifests/full/debug/AndroidManifest.xml:136:35-46 : No resource found that matches the given name (at 'resource' with value '@xml/widget').

an idea why?

@barbeau
Copy link
Member Author

barbeau commented Oct 14, 2015

I don't recall if this diff builds or not - at the time I was more focused on capturing the changes so we could review at a later date.

Looking at the above comments, I'm guessing the build fails because they were requiring a higher Android versions than us.

@kalon33
Copy link
Contributor

kalon33 commented Oct 15, 2015

@barbeau I kept the version changes and tried to build against API 22 when getting this error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barbeau @vreixo @kalon33