[CBRD-24883] combine with oracle_style_number_return parameter #4484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctshim
approved these changes
Jul 12, 2023
hgryoo
approved these changes
Jul 12, 2023
hyunikn
approved these changes
Jul 12, 2023
|
We need to discuss renaming "oracle_style_number_return" to "oracle_compat_number_behavior" (just an example) due to the parameter's changing effects when combined with other parameters. |
hgryoo
requested changes
Jul 12, 2023
I applied the parameter as your opinion. |
hgryoo
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-24883
It needs to merge two system parameters oracle_style_number_return and oracle_style_divide into one oracle_style_number_return.
There is no need to maintain two oracle-style number-related parameters. That is, the two parameters oracle_style_divide and oracle_style_number_return are unlikely to be used separately, so it is better to combine them into one.