[CBRD-24606] refactoring pr_midxkey_compare() #4025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctshim
requested review from
hgryoo,
hyunikn,
shparkcubrid,
youngjinj and
beyondykk9
youngjinj
reviewed
Jan 4, 2023
src/object/object_primitive.c
Outdated
Comment on lines
7858
to
7859
| adv_size = pr_midxkey_element_disk_size (mem1, dom1); | ||
| mem1 += adv_size; |
There was a problem hiding this comment.
How about below?
Suggested change
| adv_size = pr_midxkey_element_disk_size (mem1, dom1); | |
| mem1 += adv_size; | |
| mem1 += pr_midxkey_element_disk_size (mem1, dom1); |
There was a problem hiding this comment.
I thought Optimizer would take care of that.
I thought it would be nice to have a variable to put the value in for debugging in case.
youngjinj
approved these changes
Jan 4, 2023
shparkcubrid
approved these changes
Jan 4, 2023
beyondykk9
approved these changes
Jan 5, 2023
hyunikn
approved these changes
Jan 5, 2023
youngjinj
reviewed
Jan 5, 2023
Comment on lines
+18855
to
18858
| if (dom_is_desc[0]) | ||
| { | ||
| c = ((c == DB_GT) ? DB_LT : (c == DB_LT) ? DB_GT : c); | ||
| } |
There was a problem hiding this comment.
Shouldn't it be handled inside pr_midxkey_compare?
There was a problem hiding this comment.
It's possible, but it's not appropriate because you need to add an agreement.
There was a problem hiding this comment.
I found out that this part should not be included because pr_midxkey_compare() is not used only for index sorting.
hgryoo
approved these changes
Jan 9, 2023
…toring_pr_midxkey_compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-24606