[CBRD-24600] Problem with creating the same index with different names #4020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctshim
requested review from
beyondykk9,
hgryoo,
hyunikn,
shparkcubrid and
youngjinj
hgryoo
reviewed
Dec 29, 2022
Comment on lines
-4129
to
+4141
| { | ||
| if (filter_predicate) | ||
| { | ||
| if (!cons->filter_predicate) | ||
| { | ||
| continue; | ||
| } | ||
| if (i != len) | ||
| { | ||
| continue; | ||
| } | ||
|
|
||
| if (!filter_predicate->pred_string || !cons->filter_predicate->pred_string) | ||
| { | ||
| continue; | ||
| } | ||
| if (filter_predicate) | ||
| { |
There was a problem hiding this comment.
Checking cons->filter_predicate seems to be removed.
There was a problem hiding this comment.
Due to the conditions added to the 4105 line,
If filter_predicate is not NULL, cons->filter_predicate is also determined to be NULL.
(filter_predicate && !cons->filter_predicate) || (!filter_predicate && cons->filter_predicate)
hgryoo
approved these changes
Dec 30, 2022
hyunikn
approved these changes
Jan 2, 2023
beyondykk9
approved these changes
Jan 2, 2023
shparkcubrid
approved these changes
Jan 4, 2023
youngjinj
approved these changes
Jan 4, 2023
ctshim
added a commit
to ctshim/cubrid
that referenced
this pull request
Jan 16, 2023
CUBRID#4020) http://jira.cubrid.org/browse/CBRD-24600 * fix classobj_check_index_compatibility() and classobj_find_constraint_by_attrs() * with function index
mhoh3963
pushed a commit
that referenced
this pull request
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-24600
The classobj_find_constraint_by_attrs() function is the role of checking whether an index with the same configuration already exists.
The cause of the problem was that the function did not include function index information in the check target of the same configuration.
classobj_check_index_compatibility() was checking if the function index information was the same.
For example, all three indexes below use column val.
create index idx_a on tbl(val);
create index idx_b on tbl(abs(val));
create index idx_c on tbl(val);
case1) If you attempt to create idx_c after creating it in the order of idx_a and idx_b
The classobj_find_constrain_by_attrs() function returns idx_a.
In classobj_check_index_compatibility(), idx_c and idx_a are determined to have the same configuration and do not generate idx_c.
case2) If you attempt to create idx_c after creating it in the order of idx_b and idx_a
The classobj_find_constrain_by_attrs() function returns idx_b.
In classobj_check_index_compatibility(), idx_c and idx_b are determined to have different configurations and will generate idx_c.
So, here's the correction: