[CBRD-21754] Add __declspec(dllexport) macro in porting.h for windows #3759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyondykk9
approved these changes
Aug 5, 2022
mhoh3963
approved these changes
Aug 7, 2022
hgryoo
added a commit
to hgryoo/cubrid
that referenced
this pull request
Mar 16, 2023
…CUBRID#3759) http://jira.cubrid.org/browse/CBRD-21754 Motivation the legacy macro, EXPORT_VAR, IMPORT_VAR is not used in every place. We have the .def files to specify exporting functions. But the lists are not managed well, and it is also a burden for developers. Also, For C++ classes, when you want to export the functions in a class, every function should be explicitly specified in the .def file. Implementation As a first step of removing *.def file, I've added the MSVC keywords macro to export/import symbols to/from WIndows DLL's in porting.h. Remarks N/A
hgryoo
added a commit
to hgryoo/cubrid
that referenced
this pull request
Mar 16, 2023
…CUBRID#3759) http://jira.cubrid.org/browse/CBRD-21754 Motivation the legacy macro, EXPORT_VAR, IMPORT_VAR is not used in every place. We have the .def files to specify exporting functions. But the lists are not managed well, and it is also a burden for developers. Also, For C++ classes, when you want to export the functions in a class, every function should be explicitly specified in the .def file. Implementation As a first step of removing *.def file, I've added the MSVC keywords macro to export/import symbols to/from WIndows DLL's in porting.h. Remarks N/A
hgryoo
added a commit
to hgryoo/cubrid
that referenced
this pull request
Mar 16, 2023
…CUBRID#3759) http://jira.cubrid.org/browse/CBRD-21754 Motivation the legacy macro, EXPORT_VAR, IMPORT_VAR is not used in every place. We have the .def files to specify exporting functions. But the lists are not managed well, and it is also a burden for developers. Also, For C++ classes, when you want to export the functions in a class, every function should be explicitly specified in the .def file. Implementation As a first step of removing *.def file, I've added the MSVC keywords macro to export/import symbols to/from WIndows DLL's in porting.h. Remarks N/A
hgryoo
added a commit
that referenced
this pull request
Mar 17, 2023
…a SP is not working on Windows (#4182) http://jira.cubrid.org/browse/CBRD-24434 #3759, #3754, and #4010 should be merged to support correctly returning cursor functionality on windows. The legacy libcas cause the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-21754
Motivation
the legacy macro, EXPORT_VAR, IMPORT_VAR is not used in every place.
We have the .def files to specify exporting functions. But the lists are not managed well, and it is also a burden for developers.
Also, For C++ classes, when you want to export the functions in a class, every function should be explicitly specified in the .def file.
Implementation
As a first step of removing *.def file, I've added the MSVC keywords macro to export/import symbols to/from WIndows DLL's in porting.h.
Remarks
N/A