Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-24387] Rewrite page handling for overflow oid in btree #3748

Merged
merged 26 commits into from
Aug 24, 2022

Conversation

ctshim
Copy link
Contributor

@ctshim ctshim commented Jul 27, 2022

http://jira.cubrid.org/browse/CBRD-24387

  • Perform unnecessary code cleanup and rewrite without changing functionality.
  • The btree_rv_save_keyval_for_undo_two_objects() is called with BTREE_OVERFLOW_NODE only.
  • Fix BTREE_INIT_MVCC_HEADER()
  • Fix heap_attrinfo_generate_key()
    When func_index_info is set, information necessary for single key generation is read from this function.
  • Change space_slot_size() and space_header_size() from a function to a macro.
  • The following functions were subdivided.
    xbtree_load_index(), btree_construct_leafs(), online_index_builder(), xbtree_load_online_index()
  • Remove scan_cache argument from heap_attrinfo_read_dbvalues()

@ctshim ctshim self-assigned this Jul 27, 2022
src/storage/slotted_page.h Outdated Show resolved Hide resolved
src/storage/page_buffer.h Outdated Show resolved Hide resolved
src/storage/heap_file.c Outdated Show resolved Hide resolved
OID orig_oid;
OID orig_class_oid;
MVCC_REC_HEADER orig_mvcc_header;
} S_PARAM_ST;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does mean S_PARAM_ST? sort parameter structure?

Copy link
Contributor Author

@ctshim ctshim Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary structures have been defined to reduce what will be passed to the parameters of the function.
There is no particular meaning to the name of the structure.

{
break;
}
if (sc != S_SUCCESS)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is trivial.
Is it to reduce comparison in case of S_SUCCESS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, to reduce comparisons of if statement.

@ctshim ctshim merged commit 436ff44 into CUBRID:develop Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants