-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CBRD-24387] Rewrite page handling for overflow oid in btree #3748
Conversation
OID orig_oid; | ||
OID orig_class_oid; | ||
MVCC_REC_HEADER orig_mvcc_header; | ||
} S_PARAM_ST; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does mean S_PARAM_ST? sort parameter structure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporary structures have been defined to reduce what will be passed to the parameters of the function.
There is no particular meaning to the name of the structure.
{ | ||
break; | ||
} | ||
if (sc != S_SUCCESS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is trivial.
Is it to reduce comparison in case of S_SUCCESS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, to reduce comparisons of if statement.
http://jira.cubrid.org/browse/CBRD-24387
When func_index_info is set, information necessary for single key generation is read from this function.
xbtree_load_index(), btree_construct_leafs(), online_index_builder(), xbtree_load_online_index()