Disassemble instructions using current CPU state #256
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichardson
force-pushed
the
fix-disasm-state
branch
from
d09d659
to
23ffe96
Compare
bsdjhb
approved these changes
Jul 1, 2024
While this means we have to allocate a temporary buffer for the textual trace format, I don't see another workaround for the fact that we print the instruction disassembly after the instruction has executed and therefore has modified state (such as env->thumb) that affects the disassembly of instructions. Fixes: #255
arichardson
force-pushed
the
fix-disasm-state
branch
from
23ffe96
to
35e2496
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this means we have to allocate a temporary buffer for the textual trace format, I don't see another workaround for the fact that we print the instruction disassembly after the instruction has executed and therefore has modified state (such as env->thumb) that affects the disassembly of instructions.
Fixes: #255