Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(lines) Trim colors before using them (Safari bugfix) #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bramus
Copy link

@bramus bramus commented Dec 11, 2020

There's this issue in Safari where the lines code does not play nice with colors when they are referred to by their name.

Will work:

--lines-colors: #f94144, #f3722c, #f8961e;

Won't work:

--lines-colors: red, green, blue;

Safari only seems to correctly apply the first color:

Screenshot 2020-12-11 at 10 06 20

(You can also see this in the demo that's currently on houdini.how, where the colors are set to gold, plum, skyblue — only gold will be drawn)

The problem has to do with whitespaces: Safari apparently can't handle " green" (note the extra space).

This PR adds a small addition to the code so that it trims each color that's being parsed. That way " green" will become "green".

With the fix applied, Safari handles it just fine:

Screenshot 2020-12-11 at 10 06 35

@bramus
Copy link
Author

bramus commented Dec 11, 2020

Hah, should've checked the issue list first … duplicate of #5.

¯_(ツ)_/¯

@bramus bramus closed this Dec 11, 2020
@nucliweb nucliweb reopened this Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants