(lines) Trim colors before using them (Safari bugfix) #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's this issue in Safari where the lines code does not play nice with colors when they are referred to by their name.
Will work:
Won't work:
Safari only seems to correctly apply the first color:
(You can also see this in the demo that's currently on houdini.how, where the colors are set to
gold, plum, skyblue
— onlygold
will be drawn)The problem has to do with whitespaces: Safari apparently can't handle
" green"
(note the extra space).This PR adds a small addition to the code so that it trims each color that's being parsed. That way
" green"
will become"green"
.With the fix applied, Safari handles it just fine: