Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keywords as list instead of array #390

Merged
merged 1 commit into from
Apr 1, 2022
Merged

keywords as list instead of array #390

merged 1 commit into from
Apr 1, 2022

Conversation

blankdots
Copy link
Contributor

Description

Related issues

closes #385

also the changes merged via #386 seemed lost in #356

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  1. modify schema for doi to be of type string instead of array
  2. this will require keywords be split by comma into an array when added to Metax API

Testing

  • Tests do not apply

@blankdots blankdots requested a review from genie9 April 1, 2022 06:28
@blankdots blankdots self-assigned this Apr 1, 2022
@blankdots blankdots requested a review from hannyle April 1, 2022 06:31
@blankdots blankdots merged commit 87f204f into feature/metax-integration Apr 1, 2022
@blankdots blankdots deleted the feature/keywords-string branch April 1, 2022 11:05
@blankdots blankdots mentioned this pull request Apr 7, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannyle hannyle hannyle approved these changes

@genie9 genie9 genie9 approved these changes

Assignees

@blankdots blankdots

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blankdots @genie9 @hannyle