Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keywords as list instead of array #386

Merged
merged 1 commit into from
Mar 30, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- JSON schemas #332
- introduce `keywords` required for Metax in `doiInfo`
- dataset `description` and study `studyAbstract` are now mandatory
- `keywords` will be comma separated values, that will require splitting when adding to Metax API

### Fixed

Expand Down
8 changes: 2 additions & 6 deletions metadata_backend/helpers/schemas/datacite.json
Original file line number Diff line number Diff line change
Expand Up @@ -163,13 +163,9 @@
"uniqueItems": true
},
"keywords": {
"type": "array",
"type": "string",
"title": "Keywords",
"description": "A keyword or tag describing the resources. It is recommended to use a controlled vocabulary, ontology or classification when choosing keywords. At least one keyword is required.",
"items": {
"minLength": 1,
"type": "string"
}
"description": "A list of keywords or tags describing the resources. It is recommended to use a controlled vocabulary, ontology or classification when choosing keywords. Multiple keywords can be added, separating them by comma."
},
"contributors": {
"type": "array",
Expand Down
8 changes: 2 additions & 6 deletions metadata_backend/helpers/schemas/folders.json
Original file line number Diff line number Diff line change
Expand Up @@ -213,13 +213,9 @@
"uniqueItems": true
},
"keywords": {
"type": "array",
"type": "string",
"title": "Keywords",
"description": "A keyword or tag describing the resources. It is recommended to use a controlled vocabulary, ontology or classification when choosing keywords. At least one keyword is required.",
"items": {
"minLength": 1,
"type": "string"
}
"description": "A list of keywords or tags describing the resources. It is recommended to use a controlled vocabulary, ontology or classification when choosing keywords. Multiple keywords can be added, separating them by comma."
},
"contributors": {
"type": "array",
Expand Down
5 changes: 1 addition & 4 deletions tests/test_files/doi/test_doi.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,7 @@
"subjectScheme": "Fields of Science and Technology (FOS)"
}
],
"keywords": [
"test",
"keyword"
],
"keywords": "test,keyword",
"contributors": [
{
"name": "Contributor, Test",
Expand Down