Refactor/patch object on save #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filename is needed for db entry (fileName and displayTitle) when new object created from file and is assigned to folder.
Moving responsibility for adding newly created object to a folder from frontend to object endpoint. Now folder id is required query parameter with POST object/. Tests updated.
Update spelling wordlist.
genie9
force-pushed
the
refactor/patch-object-on-save
branch
from
135af96 to
2b078c9
Compare
blankdots
approved these changes
Feb 24, 2022
There was a problem hiding this comment.
seems front-end is ready with updates CSCfi/metadata-submitter-frontend#672
@genie9 can we merge this ?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move responsibility of adding an object to a folder on object creation and update from frontend to object endpoint.
###Related issues
Closes #335
Type of change
Frontend now should add folder ID as a query parameter with object POST.
Changes Made
Folder id is now required query param with object POST.
A folder is patched after an object is created and updated.
Adds extraction of title for folder's objects display title.
Testing