Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/hadlers #319

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Refactor/hadlers #319

merged 2 commits into from
Dec 29, 2021

Conversation

genie9
Copy link
Contributor

@genie9 genie9 commented Dec 28, 2021

Description

Refactors most handler classes to own files and updates tests to the new setup.

Type of change

Refactoring

Changes Made

Separated most of the handlers to own files inside the handlers folder.
Refactored tests for a new setup.
Fixed imports in server.py.

Testing

  • Unit Tests

@genie9 genie9 requested a review from blankdots December 28, 2021 13:03
@genie9 genie9 linked an issue Dec 28, 2021 that may be closed by this pull request
Refactor handlers #320
Closed
blankdots
blankdots suggested changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the naming scheme could be also simpler:

from .api.handlers.api
from .api.handlers.folder
from .api.handlers.object
from .api.handlers.submission
from .api.handlers.user

no need for the _handler at the end as we already have the module handlers

metadata_backend/api/handlers/api_handlers.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@genie9
Refactors handlers and their tests
6df4a65 
Separated most of handlers to own files inside handlers folder.
Refactored tests for new set up.
Fixed imports in server.py.
@genie9 genie9 requested a review from blankdots December 29, 2021 10:43
blankdots
blankdots approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks way manageable now.

@blankdots blankdots added the enhancement New feature or request label Dec 29, 2021
@genie9 genie9 merged commit 7eaba42 into develop Dec 29, 2021
@genie9 genie9 deleted the refactor/hadlers branch December 29, 2021 11:02
@blankdots blankdots mentioned this pull request Apr 7, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blankdots blankdots blankdots approved these changes

Assignees

@genie9 genie9

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor handlers
2 participants
@genie9 @blankdots