Feature/find by name #305
Merged
Feature/find by name #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genie9
force-pushed
the
feature/find-by-name
branch
9 times, most recently
from
dec2e3c to
cd54b09
Compare
Adds docker-compose configuration for mongo container to run script on newly initialized database. Adds js script to build database collections and indexes.
Folder is updated with new field text_name which is populated during folder creation from folder name as delimiter splited words. This ensures filtering name with string. Schema is updated with new field.
genie9
force-pushed
the
feature/find-by-name
branch
2 times, most recently
from
cbc448b to
713f3fc
Compare
blankdots
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
small suggestions of improvement and maybe we want to update the docs with this PR or a follow-up one, namely the https://github.com/CSCfi/metadata-submitter/blob/master/docs/test.rst#integration-testing section
Adds python script for collections and indexes creation to be run if database is destroyed. Updates clean_db script with new functionality to only delete documents from collection. Old functionality ergo dropping database can be run with flag `--purge`.
Adds dependencies and configs to be able running integration tests on local environment.
Add env vars to github workflow file as database scripts and integration tests use environment variables.
genie9
force-pushed
the
feature/find-by-name
branch
from
713f3fc to
d0c83ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds functionality to filter folders by folder name eg.
/folders?name="test string".The folder collection is updated with the new field
text_namewhich is populated during folder creation from folder name as delimiter separated words e.g 'test_file' becomes 'test file'. This field is indexed so a text search would be possible.The database is indexed during database container initialization.
Related issues
Feature #280
Type of change
Changes Made
Add indexing on database initialization
newly initialized database.
Add new field
text_nameto folder collectiontext_namewhich is populatedduring folder creation from folder name as delimiter separated words.
Add folder querying by name.
Python scripts for database operations
the database is destroyed.
documents from collections. Old functionality ergo dropping database
can be run with the flag
--purge.Add openapi specs.
Minor changes:
to make it easier to run stuff in the local environment.
Testing
Mentions