Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/prevent draft version alert popping incorrectly #95

Merged
merged 25 commits into from
Nov 11, 2020
Merged

Bugfix/prevent draft version alert popping incorrectly #95

merged 25 commits into from
Nov 11, 2020

Conversation

saulipurhonen
Copy link
Contributor

Description

Use draft status as state. Monitor this state when navigating between steps and object / submission types.

Related issues

Fixes #77 and #93

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Changes Made

  • Monitor draft status and fire draft dialog if unsaved changes
  • Destroy object card component after object / submission type change to prevent memory leaks
  • Check if form is edited and set draft status
  • Updated tests to match current code

Testing

  • Tests do not apply

Mentions

@lilachic initialized draft status state.

lilachic and others added 23 commits October 19, 2020 14:59
@lilachic
add draftStatusSlice for reducer
1174a8e
@lilachic
refactor to dispatch xml file not saved from hidden field
e3e9f7c
@lilachic
add check for xml file draft status
a6bae02
@lilachic
rebase develop branch
34e3284
@lilachic
merge fix
abad770
@lilachic
test changes
456a165
@saulipurhonen
Merge branch 'bugfix/prevent-draft-version-alert-popping-incorrectly'…
cf850d2 
… of https://github.com/CSCfi/metadata-submitter-frontend into bugfix/prevent-draft-version-alert-popping-incorrectly
@saulipurhonen
Check against drafStatus slice
1146c1f
@saulipurhonen
Testing with useRef
53478c3
@saulipurhonen
Commented out conflicting code
1784d67
@saulipurhonen
Use form component with key, this destroys the component when object …
b0ec3b3 
…type changes and prevents memory leaks
@saulipurhonen
Reset form with working function
7b484b1
@saulipurhonen
Handle form if draftStatus is set, reset draftStatus if user discards…
858f750 
… or saves form
@saulipurhonen
Added draftStatus slice to store
6797911
@saulipurhonen
RNG on XML upload component key
629875d
@saulipurhonen
Removed log
5341e6b
@saulipurhonen
Check if upload is dirty and set state
d2d6d7a
@saulipurhonen
Merge branch 'develop' into bugfix/prevent-draft-version-alert-poppin…
712db77 
…g-incorrectly
@saulipurhonen
Clear timeout in useEffect
b4befaf
@saulipurhonen
Use combination of current objectType and submissionType as key for c…
b844a52 
…omponents
@saulipurhonen
Changes to card render. XML upload has changes in state transfer so t…
ed22a8f 
…est needs to be wrapped in await act
@saulipurhonen
Wrapped tests in async
62a7c08
@saulipurhonen
Reset draft status after successful submission
16aceb1
@saulipurhonen saulipurhonen added bug Something isn't working enhancement New feature or request labels Nov 11, 2020
@saulipurhonen saulipurhonen self-assigned this Nov 11, 2020
This was linked to issues Nov 11, 2020
Fix "draft version" alert from popping up on clicks where it shouldn't #77
Closed
Changing form submission between object types causes too many re-renders #93
Closed
lilachic
lilachic approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@lilachic lilachic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plenty of places to handle draftStatus.

@blankdots blankdots merged commit 2bcbecd into develop Nov 11, 2020
@blankdots blankdots deleted the bugfix/prevent-draft-version-alert-popping-incorrectly branch November 11, 2020 15:44
@blankdots blankdots mentioned this pull request Nov 23, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilachic lilachic lilachic approved these changes

@blankdots blankdots blankdots approved these changes

@csc-jm-zz csc-jm-zz Awaiting requested review from csc-jm-zz

Assignees

@saulipurhonen saulipurhonen

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@saulipurhonen @blankdots @lilachic