Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/formik to react hook form migration #87

Merged
merged 42 commits into from
Nov 5, 2020
Merged

Feature/formik to react hook form migration #87

merged 42 commits into from
Nov 5, 2020

Conversation

saulipurhonen
Copy link
Contributor

Description

This pull request handles both component tests and migration from Formik to React Hook Form.

Related issues

Fixes #84 and #71

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • Use React Testing Library for tests
  • Added integration tests for components
  • Migrated from Formik to React Hook Form
  • Formik was used in folder creation and xml upload
  • Updated arcitecture.md to match current state of form tools

Testing

  • Integration Tests

@saulipurhonen
Wizard alert tests
1b0f124
@saulipurhonen
Fixed typo
693e975
@saulipurhonen
Created tests folder and moved tests there. Moved enzyme config to src
bbeba96
@saulipurhonen
Installed snapshot-diff package for tests
a9e5fc3
@saulipurhonen
Tests for stepper and footer
aa14cbf
@saulipurhonen
Fixed home path for save dialog
fd631bd
@saulipurhonen
Basic test
827770b
@saulipurhonen
Added more expectations
a33fcc5
@saulipurhonen
Removed debug
4bbc3bb
@saulipurhonen
Rephrased comment
7646e2a
@saulipurhonen
Migrated from Enzyme to React testing library
b5186a2
@saulipurhonen
Migrated from Enzyme to RTL
9e226b7
@saulipurhonen
Enzyme config isn't needed anymore since we're using RTL instead
95eadbb
@saulipurhonen
Uninstalled Enzyme
900b7b8
@saulipurhonen
Rephrashed test
aaa464d
@saulipurhonen
Installed @testing-library/user-event
de2a017
@saulipurhonen
Base test for xml upload
c2735dc
@saulipurhonen
Updated vulnerable packages
f58d932
@saulipurhonen
Updated React and outdated packages
b346df2
@saulipurhonen
jsdom-sixteen env config with tests
11b8622
@saulipurhonen
Removed snapshot test and snapshot file
afd36d9
@saulipurhonen
Removed snapshot test and snapshot file
5068c25
@saulipurhonen
Removed snapshot test and snapshot file
e75ac88
@saulipurhonen
Test for dialog
ac4a92c
@saulipurhonen
Test that upload for file works
d97bc2c
@saulipurhonen
Synced with package.json
2d7024a
@saulipurhonen
Added test-id attributes to help with integration tests
812f568
@saulipurhonen
Object card render tests
e5316f6
@saulipurhonen
Removed log
99bc1d1
@saulipurhonen
Container width for small screens
9b7fc11
@saulipurhonen
Basic test for form rendering from localStorage
90e74a4
@saulipurhonen
Installed localstorage mock package for Jest
5d22bee
@saulipurhonen
Migrated from Formik to React Hook Form
9c00e05
@saulipurhonen
Removed response.ok status check for error message. This is handled a…
7b42998 
…lready in error handler
@saulipurhonen
Removed dispatch logic for error message since it's not needed in rea…
b6d4f29 
…ct hook forms
@saulipurhonen
Changed comment to point from Formik to React Hook Form
a1bc0d0
@saulipurhonen
HTMLFormElement as reference for folder creation
e4096d9
@saulipurhonen
Migrated from Formik to react-hook-form
5134043
@saulipurhonen
Trigger folder creation submit with dispatchEvent from ref. Moved inc…
07c5bfc 
…rement dispatch for folder creation to WizardCreateFolderStep
@saulipurhonen
Updated 'Form components' section to match current use of react-hook-…
c28748f 
…form.
@saulipurhonen
Uninstalled Formik
2975e71
@saulipurhonen saulipurhonen self-assigned this Nov 4, 2020
This was linked to issues Nov 4, 2020
Investigate if all forms can be moved to work with react-hook-forms #71
Closed
Wizard component tests #84
Closed
csc-jm-zz
csc-jm-zz reviewed Nov 4, 2020
View reviewed changes
Copy link

@csc-jm-zz csc-jm-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good and testing around with this branch yielded no immediate noticeable errors to me. Merging #86 to this also didn't seem to cause problems.

@blankdots
Copy link
Contributor

functionality seems to be there. approved

@saulipurhonen saulipurhonen merged commit c530b86 into develop Nov 5, 2020
@saulipurhonen saulipurhonen deleted the feature/formik-to-react-hook-form-migration branch November 5, 2020 06:19
@blankdots blankdots mentioned this pull request Nov 5, 2020
Merged
2 tasks
@blankdots blankdots mentioned this pull request Nov 23, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csc-jm-zz csc-jm-zz csc-jm-zz left review comments

@blankdots blankdots blankdots approved these changes

@lilachic lilachic Awaiting requested review from lilachic

Assignees

@saulipurhonen saulipurhonen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wizard component tests Investigate if all forms can be moved to work with react-hook-forms
3 participants
@saulipurhonen @blankdots @csc-jm-zz