Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/status message handler #83

Merged
merged 9 commits into from
Oct 13, 2020
Merged

Conversation

saulipurhonen
Copy link
Contributor

Description

Created a centralized status message handler component. Both form and XML upload components had duplicate code in success and info handling. These are now with response error handling in handler component.
Added new slice for error message. This is needed to show appropriate messages in Formik module.
Error messages are shown as alerts but in snackbar.

Related issues

Closes #37

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • Moved status message logic from WizardFillObjectDetailsForm and WizardUploadObjectXMLForm components to separate component
  • Show error messages in snackbar
  • Installed Enzyme test kit
  • Use global state for error messages

Testing

  • Unit Tests

@saulipurhonen
Copy link
Contributor Author

Note:
To test snackbar, change services/objectAPI baseurl to something different and try to save a form.

@blankdots blankdots merged commit 6e954a5 into develop Oct 13, 2020
@blankdots blankdots deleted the feature/status-message-handler branch October 13, 2020 07:17
@csc-jm-zz csc-jm-zz mentioned this pull request Oct 19, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants