Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change http --> https #813

Merged
merged 2 commits into from
May 27, 2022
Merged

Change http --> https #813

merged 2 commits into from
May 27, 2022

Conversation

hannyle
Copy link
Contributor

@hannyle hannyle commented May 25, 2022 •
edited
Loading

Description

Changing http --> https for api.ror.org because the https://test-metadata.sd.csc.fi/ requires the request to be served over https

Related issues

Fixes #810

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • Change http --> https

Testing

@hannyle hannyle self-assigned this May 25, 2022
@hannyle hannyle added bug Something isn't working frontend frontend issue labels May 25, 2022
@hannyle hannyle added this to the 0.13.1 milestone May 25, 2022
@hannyle hannyle requested review from lilachic and rquazi May 25, 2022 12:14
lilachic
lilachic approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@lilachic lilachic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@hannyle hannyle linked an issue May 27, 2022 that may be closed by this pull request
Fix link to ror.org for affiliation autocompletes #810
Closed
@hannyle hannyle merged commit 7867add into develop May 27, 2022
@hannyle hannyle deleted the bugfix/modify-ror-http-request branch May 27, 2022 09:25
@genie9 genie9 mentioned this pull request May 27, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilachic lilachic lilachic approved these changes

@rquazi rquazi Awaiting requested review from rquazi

Assignees

@hannyle hannyle

Labels
bug Something isn't working frontend frontend issue
Projects
None yet
Milestone
0.13.1
Development

Successfully merging this pull request may close these issues.

Fix link to ror.org for affiliation autocompletes
2 participants
@hannyle @lilachic