Login link #80
Merged
Login link #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
csc-jm-zz
approved these changes
Oct 7, 2020
There was a problem hiding this comment.
When you try to access /aai it never gets there but that's a backend problem, which I mentioned here: CSCfi/metadata-submitter#133 (review)
So this is probably good to go
lilachic
approved these changes
Oct 8, 2020
|
Marked as draft as I need to check how this affects dev and prod envs. there seems to be some differences. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
there needs to be additional requests made in order for the user to be displayed as logged in.
Add login functionality
Related issues
Partly fixes #11
Type of change
Changes Made
Testing
Mentions
CSCfi/metadata-submitter#133 should be approved and merged for this to work.