-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/project-id #696
Merged
Merged
Feature/project-id #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hannyle
force-pushed
the
feature/project-id
branch
2 times, most recently
from
March 10, 2022 10:03
a8d6400
to
13f4e65
Compare
hannyle
force-pushed
the
feature/project-id
branch
from
March 11, 2022 15:12
b3d2647
to
f0fcecf
Compare
teemukataja
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saulipurhonen
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handling submissions based on project identifier seems to work great and code looks clean.
I'll merge to develop branch.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on the changes in back-end CSCfi/metadata-submitter#346: Project Id is now a mandatory field in creating a new submission and template.
Related issues
Closes #625
Type of change
Changes Made
templates
was no longer underuser
but has a separate API endpoint/templates
projectId
as a mandatory parameterprojectId
in the request body in POST requests for folder and templateindex
in the request bodyCSC Project
column in Submission table in Home pageChangelog
fileTesting
Mentions