Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/project-id #696

Merged
merged 7 commits into from
Mar 28, 2022
Merged

Feature/project-id #696

merged 7 commits into from
Mar 28, 2022

Conversation

hannyle
Copy link
Contributor

@hannyle hannyle commented Mar 10, 2022

Description

Based on the changes in back-end CSCfi/metadata-submitter#346: Project Id is now a mandatory field in creating a new submission and template.

Related issues

Closes #625

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Changes Made

  • templates was no longer under user but has a separate API endpoint /templates
  • Updated GET requests for folders and templates to include projectId as a mandatory parameter
  • Included projectId in the request body in POST requests for folder and template
  • Updated PATCH request for template to include index in the request body
  • Removed CSC Project column in Submission table in Home page
  • Updated e2e tests
  • Updated Changelog file

Testing

  • Integration Tests

Mentions

  • As for now the templates are temporarily hidden in our application due to the transition of UI, the e2e tests for templates will be updated later when the new template interface is implemented.

@hannyle hannyle changed the title Feature/project Feature/project-id Mar 10, 2022
@hannyle hannyle linked an issue Mar 10, 2022 that may be closed by this pull request
@hannyle hannyle force-pushed the feature/project-id branch 2 times, most recently from a8d6400 to 13f4e65 Compare March 10, 2022 10:03
@hannyle hannyle self-assigned this Mar 10, 2022
@hannyle hannyle added the enhancement New feature or request label Mar 10, 2022
@hannyle hannyle added this to the 0.12.0 milestone Mar 10, 2022
@hannyle hannyle force-pushed the feature/project-id branch from b3d2647 to f0fcecf Compare March 11, 2022 15:12
@juhtornr juhtornr modified the milestones: 0.12.0, 0.13.0 Mar 14, 2022
Copy link

@teemukataja teemukataja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually, no code review from me (no expertise). Seems to be working nicely!

There was one visual bug with buttons in the publishing page (tested of firefox and chromium):
Screenshot from 2022-03-25 11-02-47

@hannyle
Copy link
Contributor Author

hannyle commented Mar 25, 2022

Tested manually, no code review from me (no expertise). Seems to be working nicely!

There was one visual bug with buttons in the publishing page (tested of firefox and chromium): Screenshot from 2022-03-25 11-02-47

Thanks for reviewing.
The current transition of UI causes that visual bug and it should be fixed together when that part of new UI is implemented.

Copy link
Contributor

@saulipurhonen saulipurhonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handling submissions based on project identifier seems to work great and code looks clean.

I'll merge to develop branch.

@saulipurhonen saulipurhonen merged commit fc3e7a5 into develop Mar 28, 2022
@saulipurhonen saulipurhonen deleted the feature/project-id branch March 28, 2022 06:42
@blankdots blankdots mentioned this pull request Apr 7, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

project affiliation
4 participants