Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use React Hooks by ESLint hooks rule #621

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Use React Hooks by ESLint hooks rule #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
}
],
"no-unused-vars": "off",
"react-hooks/rules-of-hooks": "error",
"@typescript-eslint/no-unused-vars": "error",
"@typescript-eslint/no-explicit-any": ["off"],
"@typescript-eslint/explicit-module-boundary-types": "off"
Expand Down
154 changes: 79 additions & 75 deletions src/components/Home/UserDraftTemplates.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import UserDraftTemplateActions from "./UserDraftTemplateActions"

import { setTemplateAccessionIds } from "features/templatesSlice"
import { useAppSelector, useAppDispatch } from "hooks"
import { ObjectInsideFolderWithTags } from "types"
import { ObjectInsideFolderWithTags, TemplateDetails } from "types"
import { formatDisplayObjectType, getUserTemplates, getItemPrimaryText, Pagination } from "utils"

const useStyles = makeStyles(theme => ({
Expand Down Expand Up @@ -69,11 +69,17 @@ const UserDraftTemplates: React.FC = () => {
const objectTypesArray = useAppSelector(state => state.objectTypesArray)
const templateAccessionIds = useAppSelector(state => state.templateAccessionIds)

const dispatch = useAppDispatch()
const templates = user.templates ? getUserTemplates(user.templates, objectTypesArray) : []

// Render when there is user's draft template(s)
const DraftList = () => {
return templates.map((draft: TemplateDetails[], index: number) => <TemplateGroup key={index} draft={draft} />)
}

const TemplateGroup = (props: { draft: TemplateDetails[] }) => {
const { draft } = props

const dispatch = useAppDispatch()
const [checkedItems, setCheckedItems] = useState(templateAccessionIds)

const handleChange = (accessionId: string) => {
Expand All @@ -87,80 +93,78 @@ const UserDraftTemplates: React.FC = () => {
dispatch(setTemplateAccessionIds(items))
}

return templates.map((draft: any) => {
const schema = Object.keys(draft)[0]
const [open, setOpen] = useState(true)
// Control Pagination
const [page, setPage] = useState(0)
const [itemsPerPage, setItemsPerPage] = useState(10)

const handleChangePage = (e: any, page: number) => {
setPage(page)
}

const handleItemsPerPageChange = (e: any) => {
setItemsPerPage(e.target.value)
setPage(0)
}

return (
<FormControl key={schema} className={classes.formControl} data-testid={`form-${schema}`}>
<FormLabel className={classes.formLabel} onClick={() => setOpen(!open)}>
<Typography display="inline" variant="subtitle1" color="textPrimary">
{formatDisplayObjectType(schema)}
</Typography>
{open ? <KeyboardArrowUpIcon /> : <KeyboardArrowDownIcon />}
</FormLabel>

<Collapse className={classes.collapse} in={open} timeout={{ enter: 150, exit: 150 }} unmountOnExit>
{draft[schema]
.slice(page * itemsPerPage, page * itemsPerPage + itemsPerPage)
.map((item: ObjectInsideFolderWithTags) => {
return (
<Grid
container
key={item.accessionId}
className={classes.formControlLabel}
data-testid={`${item.schema}-item`}
>
<Grid item xs>
<FormControlLabel
control={
<Checkbox
checked={checkedItems.find((element: string) => element === item.accessionId) !== undefined}
onClick={() => handleChange(item.accessionId)}
color="primary"
name={item.accessionId}
value={item.accessionId}
/>
}
label={
<ListItemText
primary={getItemPrimaryText(item)}
secondary={item.accessionId}
data-schema={item.schema}
/>
}
/>
</Grid>
<Grid item xs="auto">
<UserDraftTemplateActions item={item} />
</Grid>
const schema = Object.keys(draft)[0]
const [open, setOpen] = useState(true)
// Control Pagination
const [page, setPage] = useState(0)
const [itemsPerPage, setItemsPerPage] = useState(10)

const handleChangePage = (e: any, page: number) => {
setPage(page)
}

const handleItemsPerPageChange = (e: any) => {
setItemsPerPage(e.target.value)
setPage(0)
}

return (
<FormControl key={schema} className={classes.formControl} data-testid={`form-${schema}`}>
<FormLabel className={classes.formLabel} onClick={() => setOpen(!open)}>
<Typography display="inline" variant="subtitle1" color="textPrimary">
{formatDisplayObjectType(schema)}
</Typography>
{open ? <KeyboardArrowUpIcon /> : <KeyboardArrowDownIcon />}
</FormLabel>

<Collapse className={classes.collapse} in={open} timeout={{ enter: 150, exit: 150 }} unmountOnExit>
{draft[schema]
.slice(page * itemsPerPage, page * itemsPerPage + itemsPerPage)
.map((item: ObjectInsideFolderWithTags) => {
return (
<Grid
container
key={item.accessionId}
className={classes.formControlLabel}
data-testid={`${item.schema}-item`}
>
<Grid item xs>
<FormControlLabel
control={
<Checkbox
checked={checkedItems.find((element: string) => element === item.accessionId) !== undefined}
onClick={() => handleChange(item.accessionId)}
color="primary"
name={item.accessionId}
value={item.accessionId}
/>
}
label={
<ListItemText
primary={getItemPrimaryText(item)}
secondary={item.accessionId}
data-schema={item.schema}
/>
}
/>
</Grid>
<Grid item xs="auto">
<UserDraftTemplateActions item={item} />
</Grid>
)
})}

<Pagination
totalNumberOfItems={draft[schema].length}
page={page}
itemsPerPage={itemsPerPage}
handleChangePage={handleChangePage}
handleItemsPerPageChange={handleItemsPerPageChange}
/>
</Collapse>
</FormControl>
)
})
</Grid>
)
})}

<Pagination
totalNumberOfItems={draft[schema].length}
page={page}
itemsPerPage={itemsPerPage}
handleChangePage={handleChangePage}
handleItemsPerPageChange={handleItemsPerPageChange}
/>
</Collapse>
</FormControl>
)
}

// Renders when user has no draft templates
Expand Down
Loading