Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new login page #573

Merged
merged 14 commits into from
Dec 30, 2021
Merged

Feature/new login page #573

merged 14 commits into from
Dec 30, 2021

Conversation

hannyle
Copy link
Contributor

@hannyle hannyle commented Dec 13, 2021

Description

  • Introducing new Login page based on the design and switching to CSC Color scheme and font styles.
  • Updating new components with MUI v.5 and Typescript

Related issues

Closes #363 and #531

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update (this needs a follow up PR)

Changes Made

  • Switched our current color theme to CSC color system and update its typescript file theme.d.ts
  • Imported the new font Museo Sans to match with CSC Design system and declare in typescript file font.d.ts
  • Rewrote the whole Login page and some parts of Navigation bar (for Login page) according to the new UI design, with new version of MUI 5 and typescript
  • Updated cypress tests

Testing

  • Integration Tests

@hannyle hannyle marked this pull request as draft December 13, 2021 13:24
@hannyle hannyle force-pushed the feature/new-login-page branch from 8b27594 to af6f458 Compare December 17, 2021 07:10
@hannyle hannyle marked this pull request as ready for review December 17, 2021 07:28
@hannyle hannyle self-assigned this Dec 17, 2021
This was linked to issues Dec 17, 2021
Copy link
Contributor

@lilachic lilachic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Noticed that with narrow window the banner image is cut from right side thus it does not fill the container all the way to the top at at right side
Screenshot 2021-12-28 at 10 21 35
.

Copy link
Member

@rquazi rquazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :)

@hannyle hannyle force-pushed the feature/new-login-page branch from af6f458 to 9387624 Compare December 30, 2021 09:33
@hannyle hannyle force-pushed the feature/new-login-page branch from 9387624 to eb8279d Compare December 30, 2021 09:35
@hannyle
Copy link
Contributor Author

hannyle commented Dec 30, 2021

LGTM. Noticed that with narrow window the banner image is cut from right side thus it does not fill the container all the way to the top at at right side Screenshot 2021-12-28 at 10 21 35 .

This is actually more about how we decide the UI would look like on different screens. To have the exact look the best way would be having different banner images responsively for different screen sizes, but I have made a temporary fix for now, we may come up with a better solution later.

@hannyle hannyle merged commit 7af42d9 into develop Dec 30, 2021
@hannyle hannyle deleted the feature/new-login-page branch December 30, 2021 10:17
@blankdots blankdots mentioned this pull request Apr 7, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New login page Switch to CSC colour scheme and styling
4 participants