-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/enable draft update #528
Conversation
Changes to status message handling had to be made since re-rendering whole app when status message state changes would unmount certain elements, eg. dialogs. |
1cbb517
to
be89b97
Compare
Status message handler changes Prevent status message handler from re-rendering component tree
be89b97
to
e7a3c4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
e7a3c4c
to
7c47bd6
Compare
Good call. This error was caused because I typed response as optional property for Fixed by stringifying response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points. I think we could change the width once we're doing whole design overhaul. Not sure if "Clear form" button is needed. Could there be some use cases where user would want to use the template id but re-fill the form? May be we could prevent updating empty form? |
ok
let us remove |
I mean preventing empty form in front-end which is in the matter of fact implemented already. |
7c47bd6
to
bcde668
Compare
Description
Added option for user to update saved templates.
Related issues
Closes #488
Type of change
Changes Made
WizardFillObjectDetailsForm
component in a dialogTesting