Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/object title not updated #456

Merged
merged 3 commits into from
Sep 24, 2021
Merged

Conversation

hannyle
Copy link
Contributor

@hannyle hannyle commented Sep 22, 2021

Description

Fix for submitted objects and draft objects' display titles in selected folder to be updated when their titles are updated.

Related issues

Fixes #454

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • Modify saveDraftHook and replaceObjectInFolder functions to patch folder with an object's new title.

Testing

  • Integration Tests

@hannyle hannyle force-pushed the bugfix/object-title-not-updated branch from 9c676bb to e723b56 Compare September 23, 2021 06:55
@hannyle hannyle self-assigned this Sep 23, 2021
@hannyle hannyle added the bug Something isn't working label Sep 23, 2021
@hannyle hannyle added this to the Open Beta milestone Sep 23, 2021
@hannyle hannyle linked an issue Sep 23, 2021 that may be closed by this pull request
@hannyle hannyle requested a review from lilachic September 23, 2021 07:40
Copy link
Contributor

@lilachic lilachic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cypress/integration/home.spec.js Outdated Show resolved Hide resolved
@hannyle hannyle force-pushed the bugfix/object-title-not-updated branch from ce9c62c to aa34b29 Compare September 24, 2021 12:50
@hannyle hannyle merged commit c7a449d into develop Sep 24, 2021
@hannyle hannyle deleted the bugfix/object-title-not-updated branch September 24, 2021 13:16
@blankdots blankdots mentioned this pull request Apr 7, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Objects display title doesn't update when editing object
2 participants