Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/show object details #452

Merged
merged 4 commits into from
Sep 15, 2021
Merged

Conversation

saulipurhonen
Copy link
Contributor

Description

Display object details inside folder.

Related issues

Closes #410

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • Custom JSON schema parser for object details
  • Collapse details

Testing

  • Unit Tests
  • Integration Tests

@saulipurhonen saulipurhonen added the enhancement New feature or request label Sep 10, 2021
@saulipurhonen saulipurhonen added this to the Open Beta milestone Sep 10, 2021
@saulipurhonen saulipurhonen self-assigned this Sep 10, 2021
@saulipurhonen saulipurhonen marked this pull request as ready for review September 10, 2021 11:50
@saulipurhonen
Copy link
Contributor Author

Details UX isn't perfect as it is since long lists of details can be hard to view as user. One option could be tabbed layout.
Eg. on Study tab items could be Study Description, Study Links, Study Attributes & Description for Center

Layout can be handled either on this or some other PR.

@lilachic
Copy link
Contributor

Maybe UX styling belongs to adapting CSC styling?

Copy link
Contributor

@hannyle hannyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me. Well done!

I think this should be rebased onto develop branch as well.
A minor thing is some functions kinda overlap between JSONSchemaParser files, maybe we could just reuse them ? (for e.g. dereferenceSchema, pathToName)

Copy link
Contributor

@lilachic lilachic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The details look good to me.

@saulipurhonen
Copy link
Contributor Author

Looks very good to me. Well done!

I think this should be rebased onto develop branch as well.
A minor thing is some functions kinda overlap between JSONSchemaParser files, maybe we could just reuse them ? (for e.g. dereferenceSchema, pathToName)

Good points. Going to implement these changes soon.

@saulipurhonen saulipurhonen force-pushed the feature/show-object-details branch from 3efed89 to 5d4b409 Compare September 14, 2021 12:45
@saulipurhonen
Copy link
Contributor Author

Looks very good to me. Well done!

I think this should be rebased onto develop branch as well.
A minor thing is some functions kinda overlap between JSONSchemaParser files, maybe we could just reuse them ? (for e.g. dereferenceSchema, pathToName)

Introduced shared JSON schema utilities file and rebased with develop

@saulipurhonen saulipurhonen merged commit 697cfb4 into develop Sep 15, 2021
@saulipurhonen saulipurhonen deleted the feature/show-object-details branch September 15, 2021 10:35
@saulipurhonen saulipurhonen linked an issue Sep 15, 2021 that may be closed by this pull request
@blankdots blankdots mentioned this pull request Apr 7, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show details on draft and published should provide a summary
3 participants