-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/show object details #452
Conversation
Details UX isn't perfect as it is since long lists of details can be hard to view as user. One option could be tabbed layout. Layout can be handled either on this or some other PR. |
Maybe UX styling belongs to adapting CSC styling? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me. Well done!
I think this should be rebased onto develop
branch as well.
A minor thing is some functions kinda overlap between JSONSchemaParser
files, maybe we could just reuse them ? (for e.g. dereferenceSchema
, pathToName
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The details look good to me.
Good points. Going to implement these changes soon. |
3efed89
to
5d4b409
Compare
Introduced shared JSON schema utilities file and rebased with |
Description
Display object details inside folder.
Related issues
Closes #410
Type of change
Changes Made
Testing