Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add retries & disable also video compression #426

Merged
merged 2 commits into from
Aug 17, 2021
Merged

add retries & disable also video compression #426

merged 2 commits into from
Aug 17, 2021

Conversation

blankdots
Copy link
Contributor

@blankdots blankdots commented Aug 17, 2021 •
edited
Loading

Description

Add cypress test retries and disable video compression

Related issues

hopefully this makes cypress failures not so random

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  1. add 3 retries for CI
  2. remove videocompression to make CI run faster.

Testing

  • Tests do not apply

Mentions

retries might cause inconsistencies if data is not cleaned.

@blankdots blankdots self-assigned this Aug 17, 2021
@blankdots blankdots changed the title add 2 retries & disable also video compression add retries & disable also video compression Aug 17, 2021
@blankdots blankdots marked this pull request as ready for review August 17, 2021 06:26
saulipurhonen
saulipurhonen approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@saulipurhonen saulipurhonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hannyle
hannyle approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@hannyle hannyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose setting "videoCompression": false also helps reduce the file size ?

@blankdots
Copy link
Contributor Author

I suppose setting "videoCompression": false also helps reduce the file size ?

actually does the opposite, there is no video compression at all

@hannyle
Copy link
Contributor

hannyle commented Aug 17, 2021

I suppose setting "videoCompression": false also helps reduce the file size ?

actually does the opposite, there is no video compression at all

Yep, I just checked from the document: The compression step will be skipped completely, so the video will be large, but the processing should be faster.

@blankdots blankdots merged commit 7acb132 into develop Aug 17, 2021
@blankdots blankdots deleted the feature/cypress-retries branch August 17, 2021 08:37
@blankdots blankdots mentioned this pull request Aug 19, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulipurhonen saulipurhonen saulipurhonen approved these changes

@hannyle hannyle hannyle approved these changes

@lilachic lilachic Awaiting requested review from lilachic

Assignees

@blankdots blankdots

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blankdots @hannyle @saulipurhonen