Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/update json forms #40

Merged
merged 15 commits into from
Jul 27, 2020
Merged

Feature/update json forms #40

merged 15 commits into from
Jul 27, 2020

Conversation

otahontas
Copy link
Contributor

@otahontas otahontas commented Jul 22, 2020 •
edited
Loading

Description

PR adds support for form rendering & validation for all metadata object types.

Related issues

Solves #8 #17

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • Remove live validation from forms
  • Add ui schemas for each form to frontend
  • Add api service for asking schemas from backend
  • Add async form rendering, loading and error handling
  • Add theming for forms at whole app level

Testing

  • Needs testing (start an issue or do a follow up PR about it)

@otahontas otahontas requested a review from blankdots July 22, 2020 11:56
@otahontas otahontas self-assigned this Jul 22, 2020
@otahontas otahontas marked this pull request as draft July 23, 2020 05:48
@otahontas otahontas marked this pull request as ready for review July 23, 2020 08:30
@otahontas otahontas requested a review from csc-jm-zz July 24, 2020 13:39
@csc-jm-zz csc-jm-zz added the enhancement New feature or request label Jul 24, 2020
@otahontas otahontas merged commit aa8e654 into develop Jul 27, 2020
@otahontas otahontas deleted the feature/update-json-forms branch July 27, 2020 07:40
@otahontas otahontas mentioned this pull request Aug 13, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csc-jm-zz csc-jm-zz csc-jm-zz approved these changes

@blankdots blankdots blankdots approved these changes

Assignees

@otahontas otahontas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@otahontas @blankdots @csc-jm-zz