Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/400 error page #386

Merged
merged 5 commits into from
Jul 27, 2021
Merged

Bugfix/400 error page #386

merged 5 commits into from
Jul 27, 2021

Conversation

blankdots
Copy link
Contributor

@blankdots blankdots commented Jul 26, 2021 •
edited
Loading

Description

Related issues

#365

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  1. add error400 page
  2. add unit and integration tests for error400 page

Testing

  • Unit Tests
  • Integration Tests

Mentions

Requires CSCfi/metadata-submitter#240 (last commit is just for testing with that branch, and will be removed)

@blankdots blankdots added the bug Something isn't working label Jul 26, 2021
@blankdots blankdots self-assigned this Jul 26, 2021
@blankdots blankdots force-pushed the bugfix/400-error-page branch from b8144d6 to 6b3e0de Compare July 26, 2021 07:51
@blankdots blankdots linked an issue Jul 26, 2021 that may be closed by this pull request
Error page for 400 response #365
Closed
@blankdots blankdots marked this pull request as ready for review July 26, 2021 08:21
hannyle
hannyle approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@hannyle hannyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
I noticed that there is still the navigation menu on error page 400. Does it mean to be there ? (As other error pages don't have it )
Screenshot 2021-07-26 at 13 09 03

@blankdots
Copy link
Contributor Author

@hannyle I will remove it.

@blankdots blankdots force-pushed the bugfix/400-error-page branch from 6b3e0de to 8cc3b9e Compare July 26, 2021 12:35
@blankdots blankdots mentioned this pull request Jul 27, 2021
Merged
2 tasks
@blankdots blankdots force-pushed the bugfix/400-error-page branch from 8cc3b9e to 797c4f6 Compare July 27, 2021 11:18
@blankdots blankdots merged commit 5856b55 into develop Jul 27, 2021
@blankdots blankdots deleted the bugfix/400-error-page branch July 27, 2021 11:39
@blankdots blankdots mentioned this pull request Aug 11, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannyle hannyle hannyle approved these changes

@saulipurhonen saulipurhonen Awaiting requested review from saulipurhonen

@lilachic lilachic Awaiting requested review from lilachic

Assignees

@blankdots blankdots

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error page for 400 response
2 participants
@blankdots @hannyle