Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset object in state when editing submitted item #319

Merged
merged 2 commits into from
May 25, 2021
Merged

Reset object in state when editing submitted item #319

merged 2 commits into from
May 25, 2021

Conversation

saulipurhonen
Copy link
Contributor

Description

Form didn't populate when trying to edit submitted item after user has cleared the form.

Related issues

Closes #292

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • Dispatch resetCurrentObject method when clearing form

Testing

  • E2E

@saulipurhonen saulipurhonen added the bug Something isn't working label May 24, 2021
@saulipurhonen saulipurhonen added this to the Beta - User Interaction milestone May 24, 2021
@saulipurhonen saulipurhonen self-assigned this May 24, 2021
@saulipurhonen saulipurhonen marked this pull request as draft May 25, 2021 04:46
@saulipurhonen saulipurhonen marked this pull request as ready for review May 25, 2021 05:27
@saulipurhonen saulipurhonen changed the title Reset object in state when clearing form Reset object in state when editing submitted item May 25, 2021
@saulipurhonen
Copy link
Contributor Author

Changed pull request title to match current fix.

@blankdots blankdots merged commit 695aba6 into develop May 25, 2021
@blankdots blankdots deleted the bugfix/edit-submitted-object branch May 25, 2021 14:49
@blankdots blankdots mentioned this pull request Aug 11, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilachic lilachic lilachic approved these changes

@hannyle hannyle hannyle approved these changes

@blankdots blankdots blankdots approved these changes

Assignees

@saulipurhonen saulipurhonen

Labels
bug Something isn't working
Projects
None yet
Milestone
Beta - User Interaction
Development

Successfully merging this pull request may close these issues.
4 participants
@saulipurhonen @blankdots @hannyle @lilachic