Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved object type fetching from home view to application start #283

Merged
merged 3 commits into from
May 3, 2021

Conversation

saulipurhonen
Copy link
Contributor

Description

Object index array was populated only in home-route. This resulted in missing items when refreshing the app in another route, eg. /newdraft

Related issues

Closes #282

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • Moved object index fetching logic from Home.js to app root App.js

Testing

  • E2E Tests

This is covered in all E2E tests that handle wizard functionality.

@saulipurhonen saulipurhonen added the bug Something isn't working label Apr 30, 2021
@saulipurhonen saulipurhonen added this to the Beta - User Interaction milestone Apr 30, 2021
@saulipurhonen saulipurhonen self-assigned this Apr 30, 2021
@saulipurhonen saulipurhonen force-pushed the bugfix/get-object-types-on-app-start branch from a860235 to 2ba9450 Compare April 30, 2021 11:54
@saulipurhonen saulipurhonen merged commit 4942731 into develop May 3, 2021
@saulipurhonen saulipurhonen deleted the bugfix/get-object-types-on-app-start branch May 3, 2021 09:59
@blankdots blankdots mentioned this pull request Aug 11, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants