DAC is an acronym treat it as one #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
process the objecttype in utils so that we can better handle acronyms and have a consistent labels
hannyle
reviewed
Apr 8, 2021
hannyle
approved these changes
Apr 8, 2021
Co-authored-by: Hang Le <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to be able to process the object type as they are defined in the schemas yet still maintain them consistent through the UI.
DACis an acronym and should be handled as one.Related issues
My OCD kicked in regarding this and needed to solve it
Type of change
Changes Made
process the
objecttypeinutilsso that we can better handle acronyms and have a consistent labelsTesting
Mentions