Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test blur on form field #222

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Test blur on form field #222

merged 1 commit into from
Mar 31, 2021

Conversation

saulipurhonen
Copy link
Contributor

Description

AJV package update revealed untested piece on form field validation.
Validation triggers on blur and this event should be tested.

Related issues

Closes #221

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • Test blur event in WizardFillObjectDetailsForm.test.js
  • Check that data exists in forms handleChange method
  • Added test id to get the input from Material Textfield

Testing

  • Integration Tests

@saulipurhonen saulipurhonen added the enhancement New feature or request label Mar 31, 2021
@saulipurhonen saulipurhonen added this to the Beta - User Interaction milestone Mar 31, 2021
@saulipurhonen saulipurhonen self-assigned this Mar 31, 2021
@saulipurhonen saulipurhonen linked an issue Mar 31, 2021 that may be closed by this pull request
Test form field blur #221
Closed
hannyle
hannyle approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@hannyle hannyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

For Check that data exists in forms handleChange method I think we also have the function checkFormCleanedValuesEmpty. clone returns an object so I wonder if if can check the data exists.

@saulipurhonen
Copy link
Contributor Author

Looks good to me.

For Check that data exists in forms handleChange method I think we also have the function checkFormCleanedValuesEmpty. clone returns an object so I wonder if if can check the data exists.

In this particular case input field rises error in the test case if clone is undefined. It seems that deep clone takes some time and the variable wasn't ready in the next assignment. Check for clone status gets past this error.

@blankdots blankdots merged commit a6db7d8 into develop Mar 31, 2021
@blankdots blankdots deleted the feature/test-blur-events branch March 31, 2021 08:45
@blankdots blankdots mentioned this pull request Mar 31, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilachic lilachic lilachic approved these changes

@hannyle hannyle hannyle approved these changes

@blankdots blankdots blankdots approved these changes

Assignees

@saulipurhonen saulipurhonen

Labels
enhancement New feature or request
Projects
None yet
Milestone
Beta - User Interaction
Development

Successfully merging this pull request may close these issues.

Test form field blur
4 participants
@saulipurhonen @blankdots @hannyle @lilachic