Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix development environment related proxy bugs #15

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

otahontas
Copy link
Contributor

Description

Fixing bug with development proxys and docker. Also setting backend as requirement for frontend in readme.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • Change proxy settings from package.json to proxy-module. Proxy is by default "localhost:5430", unless set to different with env variable.
  • In development docker-compose, change backend proxy to be default container name for backend. Also add frontend container to same docker network with backend.
  • When files were in folder called development, docker-compose added all launched containers to project called "development" by default. This created nameclashes, but moving files to project root leads project to be called "metadata-submitter-frontend"
  • Update readme according to these fixes.

Testing

  • Tests do not apply

Mentions

Open for other solutions as well

@otahontas otahontas requested a review from blankdots June 30, 2020 05:51
@otahontas otahontas self-assigned this Jun 30, 2020
@otahontas otahontas added the bug Something isn't working label Jun 30, 2020
@otahontas otahontas merged commit 9f71a6d into develop Jun 30, 2020
@otahontas otahontas deleted the bugfix/fix-docker-dev-proxy branch June 30, 2020 09:18
@otahontas otahontas mentioned this pull request Aug 13, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants