Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for Analysis object Fill form and check Summary amount of ob… #125

Merged
merged 4 commits into from
Jan 11, 2021
Merged

Add test for Analysis object Fill form and check Summary amount of ob… #125

merged 4 commits into from
Jan 11, 2021

Conversation

hannyle
Copy link
Contributor

@hannyle hannyle commented Jan 8, 2021 •
edited
Loading

Description

Add test for filling form in Analysis object and check the Summary of objects if it has the correct amount

Related issues

#31

Changes Made

  • Extend Wizard Layout test in app.spec.js: Filling form in Analysis object and submit it
  • Test that Summary has the correct number of Study objects and Analysis object

Testing

  • e2e test

@hannyle hannyle linked an issue Jan 8, 2021 that may be closed by this pull request
Add tests for wizard layout #31
Closed
blankdots
blankdots suggested changes Jan 10, 2021
View reviewed changes
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me it fails locally due to that error could we figure out another way to click that or use {force: true} ?

cypress/integration/app.spec.js Outdated Show resolved Hide resolved
blankdots
blankdots approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typos otherwise works fine. Approved!

cypress/integration/app.spec.js Outdated Show resolved Hide resolved
cypress/integration/app.spec.js Outdated Show resolved Hide resolved
cypress/integration/app.spec.js Outdated Show resolved Hide resolved
@hannyle @blankdots
Fix Experiment typos
b4d408d 
Co-authored-by: Stefan Negru <[email protected]>
lilachic
lilachic approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@lilachic lilachic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@blankdots blankdots merged commit 307c35c into develop Jan 11, 2021
@blankdots blankdots deleted the test/wizard-layout-summary branch January 11, 2021 12:35
@blankdots blankdots mentioned this pull request Jan 14, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blankdots blankdots blankdots approved these changes

@lilachic lilachic lilachic approved these changes

@saulipurhonen saulipurhonen Awaiting requested review from saulipurhonen

Assignees

@hannyle hannyle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for wizard layout
4 participants
@hannyle @blankdots @lilachic @saulipurhonen