Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify style sheet to follow csc guidelines #4

Closed
otahontas opened this issue Jun 16, 2020 · 0 comments · Fixed by #74
Closed

Unify style sheet to follow csc guidelines #4

otahontas opened this issue Jun 16, 2020 · 0 comments · Fixed by #74
Assignees
@otahontas
Labels
enhancement New feature or request

Comments

@otahontas
Copy link
Contributor

otahontas commented Jun 16, 2020 •
edited
Loading

Proposed solution

Components should be styled better, now only program logic is working. Material UI provides quite much tools to do stylings in components (like setting <Grid xs=6>), but for app-wide stylings we should use Material UI:s makeMuiTheme -modules and .

Things that need to be set:

  • colors primary, secondary
  • consistent button layouts: bold text, non-capitalized

DoD (Definition of Done)

Components are styled in consistent way

Testing

  • Jest unit tests if needed
@otahontas otahontas added the enhancement New feature or request label Jun 16, 2020
@otahontas otahontas mentioned this issue Jun 18, 2020
Merged
2 tasks
@otahontas otahontas changed the title Add better styles for components Unify style sheet to follow csc guidelines Jul 7, 2020
@otahontas otahontas mentioned this issue Aug 3, 2020
Merged
2 tasks
@otahontas otahontas self-assigned this Aug 3, 2020
@otahontas otahontas mentioned this issue Aug 13, 2020
Merged
5 tasks
@blankdots blankdots mentioned this issue Sep 29, 2021
Closed
saulipurhonen added a commit that referenced this issue Apr 6, 2022
@saulipurhonen
Fix for folder generation in Cypress tests #4
d2d08bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otahontas otahontas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 0.3.0 CSCfi/metadata-submitter-frontend
1 participant
@otahontas