Update for cypress tests

CSCfi · Dec 16, 2021 · 99d4522 · 99d4522
1 parent eba0a98
commit 99d4522
Show file tree

Hide file tree

Showing 9 changed files with 16 additions and 10 deletions.
diff --git a/cypress/integration/draft.spec.ts b/cypress/integration/draft.spec.ts
@@ -56,6 +56,7 @@ describe("Draft operations", function () {
       .then($el => $el.click())
 
     // Fill
+    cy.get("input[name='descriptor.studyTitle']").should("be.visible")
     cy.get("input[name='descriptor.studyTitle']").type("New title")
     cy.get("input[name='descriptor.studyTitle']").should("have.value", "New title")
     cy.get("select[name='descriptor.studyType']").select("Metagenomics")

diff --git a/cypress/integration/editForm.spec.ts b/cypress/integration/editForm.spec.ts
@@ -57,7 +57,10 @@ describe("Populate form and render form elements by object data", function () {
 
     // Clear object in state
     cy.get("button[type=button]", { timeout: 10000 }).contains("New form").should("exist")
-    cy.get("button[type=button]").contains("New form").click()
+    cy.get("button[type=button]")
+      .contains("New form")
+      .should("be.visible")
+      .then($el => $el.click())
 
     // Test updated title
     cy.get(".MuiListItem-container", { timeout: 10000 }).should("have.length", 1)

diff --git a/cypress/integration/emptyForm.spec.ts b/cypress/integration/emptyForm.spec.ts
@@ -50,7 +50,10 @@ describe("empty form should not be alerted or saved", function () {
     cy.get("textarea[data-testid='description']").should("have.value", "Test experiment description")
 
     // Click Clear form button and expect the form is empty
-    cy.get("button[type='button']").contains("Clear form").click({ force: true })
+    cy.get("button[type='button']")
+      .contains("Clear form")
+      .should("be.visible")
+      .then($el => $el.click())
     cy.get("input[data-testid='title']").should("have.value", "")
     cy.get("textarea[data-testid='description']").should("have.value", "")
 

diff --git a/cypress/integration/i18n.spec.ts b/cypress/integration/i18n.spec.ts
@@ -7,8 +7,7 @@ describe("Internationalization", function () {
     cy.get("#lang-selector").click()
     cy.get("li[role=menuitem]").contains("Fi").click()
 
-    cy.get('[alt="CSC Login"]').click()
-    cy.wait(1000)
+    cy.login()
 
     cy.get("[data-testid='logged-in-as'").contains("Kirjautuneena")
   })

diff --git a/cypress/integration/linkingAccessionIds.spec.ts b/cypress/integration/linkingAccessionIds.spec.ts
@@ -3,8 +3,7 @@ describe("Linking Accession Ids", function () {
 
   it("should link correct accessionIds to the related objects", () => {
     cy.visit(baseUrl)
-    cy.get('[alt="CSC Login"]').click()
-    cy.wait(1000)
+    cy.login()
     cy.get("button", { timeout: 10000 }).contains("Create Submission").click()
 
     // Add folder name & description, navigate to submissions

diff --git a/cypress/support/commands.ts b/cypress/support/commands.ts
@@ -63,7 +63,7 @@ Cypress.on("uncaught:exception", () => {
 
 Cypress.Commands.add("login", () => {
   cy.visit(baseUrl)
-  cy.get('[alt="CSC Login"]').click()
+  cy.get('a[data-testid="login-button"]').click()
   cy.wait(1000)
 })
 

diff --git a/src/components/NewDraftWizard/WizardComponents/WizardDraftSelections.tsx b/src/components/NewDraftWizard/WizardComponents/WizardDraftSelections.tsx
@@ -58,7 +58,7 @@ const useStyles = makeStyles(theme => ({
     },
   },
   viewButton: {
-    color: theme.palette.button.edit,
+    color: theme.palette.primary.main,
     margin: theme.spacing(1.5, 0),
     float: "right",
   },
@@ -69,7 +69,7 @@ const useStyles = makeStyles(theme => ({
     justifyContent: "space-between",
     position: "sticky",
     zIndex: 1,
-    backgroundColor: theme.palette.background.default,
+    backgroundColor: theme.palette.background.paper,
     bottom: 0,
   },
 }))

diff --git a/src/theme.ts b/src/theme.ts
@@ -21,6 +21,7 @@ const palette = {
   },
   background: {
     default: "#e5eff1",
+    paper: "#fff",
   },
   success: {
     main: "#51a808",

diff --git a/src/views/Login.js b/src/views/Login.js
@@ -66,7 +66,7 @@ const Login = (): React$Element<typeof Container> => {
           SD Submit
         </Typography>
         <Typography sx={{ mt: "2.25em", color: "secondary.main" }}>Tool for submitting metadata.</Typography>
-        <LoginButton variant="contained" color="primary" href={loginRoute}>
+        <LoginButton variant="contained" color="primary" href={loginRoute} data-testid="login-button">
           Login
         </LoginButton>
       </LoginBanner>