Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable build for ARM processor architectuere #9

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

lilachic
Copy link
Contributor

To be able to run the containers at Mac M1 processor we need to provide the container images build for ARM

Changes:

  • Dockerfile

    • Add variable to pass custom made EMSDK image for building docker-container-crypt4gh Docker image for ARM.
  • README

    • Add instruction to use build arguments for custom build Docker image.

@lilachic lilachic added the enhancement New feature or request label Sep 12, 2023
@lilachic lilachic self-assigned this Sep 12, 2023
@csc-felipe
Copy link
Collaborator

Nice work with figuring out how to add support for new macs. I was thinking that if we can specify the image, perhaps we don't need two separate variables, EMSDK_IMAGE and EMSCRIPTEN_VERSION. I think it could be better user experience for this to have only EMSDK_IMAGE. or what do you think?

@lilachic
Copy link
Contributor Author

Nice work with figuring out how to add support for new macs. I was thinking that if we can specify the image, perhaps we don't need two separate variables, EMSDK_IMAGE and EMSCRIPTEN_VERSION. I think it could be better user experience for this to have only EMSDK_IMAGE. or what do you think?

good point. For building ARM we need to select locally for ARM built emsdk, that is why the option is added to use an image from custom registry.

The version of emsdk in Dockerfile was defined there, And I wanted to keep the option choosing the version of emsdk separate to the image. Not sure if we need this?

Hopefully in future we can use images build for multiplatform, same image containing both AMD and ARM versions. Then we could continue to use either official images or custom build emsdk images if needed?

@blankdots blankdots self-requested a review September 22, 2023 10:12
@blankdots
Copy link
Contributor

Hopefully in future we can use images build for multiplatform, same image containing both AMD and ARM versions. Then we could continue to use either official images or custom build emsdk images if needed?

sounds ok to me, and when this emscripten-core/emsdk#1211 is done maybe we can automate this somehow.

Environment vars, no preference there

blankdots
blankdots previously approved these changes Sep 26, 2023
@lilachic lilachic merged commit 4ddc872 into main Feb 26, 2024
2 checks passed
@lilachic lilachic deleted the feature/add-multiplatform-build branch February 26, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants