Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update wekeo sentinel product types #902

Merged
merged 15 commits into from
Nov 20, 2023
Merged

feat: update wekeo sentinel product types #902

merged 15 commits into from
Nov 20, 2023

Conversation

jlahovnik
Copy link
Collaborator

  • adaptations on sentinel 1 product types
  • add all available search parameters for all sentinel products
  • add sentinel 3 and 6 products available in wekeo and not available in EODAG so far
  • add wekeo to support providers list in documentation index page

@jlahovnik jlahovnik linked an issue Oct 26, 2023 that may be closed by this pull request
update wekeo sentinel product types #864
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023 •
edited
Loading

Test Results

       4 files  ±0         4 suites  ±0   3m 35s ⏱️ +4s
   432 tests +1     429 ✔️ +1    3 💤 ±0  0 ❌ ±0 
1 728 runs  +4  1 652 ✔️ +4  76 💤 ±0  0 ❌ ±0 

Results for commit e937210. ± Comparison against base commit 67e0943.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023 •
edited
Loading

Code Coverage (Ubuntu)

File Coverage
All files 82% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against e937210

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023 •
edited
Loading

Code Coverage (Windows)

File Coverage
All files 76% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against e937210

@alambare alambare requested a review from sbrunato October 27, 2023 10:37
sbrunato
sbrunato requested changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@sbrunato sbrunato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please

  • add S1_SAR_OCN, S1_SAR_RAW, S2_MSI_L2AP
  • rename *_REPROCESSED product types to *_BC00X.
    Ex: S3_SRA_1B_SE_REPROCESSED to S3_SRA_BS_BC004

@jlahovnik
Copy link
Collaborator Author

please

* add `S1_SAR_OCN`, `S1_SAR_RAW`, `S2_MSI_L2AP`

* rename `*_REPROCESSED` product types to `*_BC00X`.
  Ex: `S3_SRA_1B_SE_REPROCESSED` to `S3_SRA_BS_BC004`

Updated

sbrunato
sbrunato requested changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@sbrunato sbrunato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use standard metadata parameters names: relativeOrbitNumber instead of relorbit, platform instead of sat, ...

eodag/resources/product_types.yml Outdated Show resolved Hide resolved
eodag/resources/product_types.yml Outdated Show resolved Hide resolved
eodag/resources/product_types.yml Outdated Show resolved Hide resolved
eodag/resources/product_types.yml Outdated Show resolved Hide resolved
eodag/resources/product_types.yml Outdated Show resolved Hide resolved
eodag/resources/product_types.yml Outdated Show resolved Hide resolved
eodag/resources/product_types.yml Outdated Show resolved Hide resolved
eodag/resources/product_types.yml Outdated Show resolved Hide resolved
eodag/resources/product_types.yml Outdated Show resolved Hide resolved
eodag/resources/product_types.yml Outdated Show resolved Hide resolved
@jlahovnik
Copy link
Collaborator Author

please use standard metadata parameters names: relativeOrbitNumber instead of relorbit, platform instead of sat, ...

all changes done

@alambare alambare requested a review from sbrunato November 16, 2023 16:40
sbrunato
sbrunato requested changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@sbrunato sbrunato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change properties:

  • type to providerProductType
  • cycle to cycleNumber

@jlahovnik
Copy link
Collaborator Author

Please change properties:

* `type` to `providerProductType`

* `cycle` to `cycleNumber`

done

@alambare alambare requested a review from sbrunato November 17, 2023 13:34
@sbrunato sbrunato force-pushed the 864-update-wekeo-sentinel-product-types branch from ce0c2ff to 71265fb Compare November 20, 2023 14:25
@sbrunato sbrunato changed the title 864 update wekeo sentinel product types feat: update wekeo sentinel product types Nov 20, 2023
@sbrunato sbrunato merged commit 9e881ac into develop Nov 20, 2023
11 checks passed
@sbrunato sbrunato deleted the 864-update-wekeo-sentinel-product-types branch November 20, 2023 15:00
@sbrunato sbrunato added this to the 2.11.0 milestone Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunato sbrunato sbrunato approved these changes

Assignees

@jlahovnik jlahovnik

Labels
None yet
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

update wekeo sentinel product types
2 participants
@jlahovnik @sbrunato