This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Added localized string for various texts in city overview #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed fixed english strings to localized ones where it should not conflict with line height.
|
I had completely neglected to consider localization when I accepted the PR for the amenities overhaul. Thank you for catching that and correcting it! |
|
Might want to look what to do with localized texts over multiple lines, probably splitting and setting it in the function, was able to check (and understand) it in english and german, seemed fine for both. Apparently there's no localization for "Entertainment" though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed fixed english strings to localized ones where it should not
conflict with line height.