fix: supporting encoding const-parametrized ops #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborgna-q
approved these changes
Sep 5, 2023
src/circuit/command.rs
Outdated
Comment on lines
107
to
109
| optype | ||
| .static_input() | ||
| .map(|_| PortOffset::new_incoming(sig.input.len()).into()), |
There was a problem hiding this comment.
Ideally we shouldn't need to access portgraph primitives, nor should we set here what's the offset of the static input.
I can add an issue in hugr to implement an OpType::static_input_port (similar to OpType::other_port).
|
|
||
| // TODO: Update op.params. Leave untouched the ones that contain free variables. | ||
| let mut op: circuit_json::Operation = op.into_operation(); | ||
| if !params.is_empty() { |
There was a problem hiding this comment.
With this we recover all parameters that have been encoded as inputs. It should be easy to support transparent pass-through of parameters we don't understand yet (e.g. x+1) and retrieve them from the metadata here.
This is OK for now, but I'll add a followup issue.
Co-authored-by: Agustín Borgna <[email protected]>
just use 0 directly and add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactor json tests to use fixtures (easier to add new ones)
Check some command equality in those tests for circuits with matching command ordering (could parametrise the comparison function in future to skip this)