refactor: simplify json encoding using t2op #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss2165
force-pushed
the
refactor/json-t2op
branch
from
7a4360d
to
03b3762
Compare
aborgna-q
approved these changes
Sep 4, 2023
src/json/op.rs
Outdated
Comment on lines
218
to
220
| _ => { | ||
| return Err(err()); | ||
| } |
There was a problem hiding this comment.
Suggested change
| _ => { | |
| return Err(err()); | |
| } | |
| _ => return Err(err()), |
| #[derive(Debug, Error, PartialEq, Clone, Copy)] | ||
| #[error("Not a T2Op.")] | ||
| pub struct NotT2Op; | ||
|
|
||
| // this trait could be implemented in Hugr |
There was a problem hiding this comment.
Suggested change
| // this trait could be implemented in Hugr |
not anymore
There was a problem hiding this comment.
made more generic so that this remains true hopefully
src/ops.rs
Outdated
| ExternalOp::Extension(e) => Self::try_from_op_def(e.def()), | ||
| ExternalOp::Opaque(o) => from_extension_name(o.extension(), o.name()), | ||
| } | ||
| .map_err(|_| "not a T2Op"), |
There was a problem hiding this comment.
Use NotT2Op as the TryFrom error?
ss2165
force-pushed
the
refactor/json-t2op
branch
from
f555e24
to
dfe5e8c
Compare
ss2165
force-pushed
the
refactor/json-t2op
branch
from
dfe5e8c
to
3f4cecd
Compare
aborgna-q
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.