Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use T2Op in pattern matching #69

Merged
merged 5 commits into from
Sep 1, 2023
Merged

refactor: Use T2Op in pattern matching #69

merged 5 commits into from
Sep 1, 2023

Conversation

lmondada
Copy link
Contributor

No description provided.

@lmondada
Copy link
Contributor Author

This should make you happy :)

aborgna-q
aborgna-q reviewed Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we cannot match LoadConstant anymore?

@lmondada
Copy link
Contributor Author

Ahh, yes, I might not have thought this through. Should we then have:

pub enum MatchOp {
    Op(T2Op),
    LoadConstant,
}

@aborgna-q
Copy link
Collaborator

Yeah, that should work.

@lmondada lmondada merged commit 5d5d6e7 into main Sep 1, 2023
5 checks passed
@lmondada lmondada deleted the refactor/rm-matchop branch September 1, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aborgna-q aborgna-q aborgna-q approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmondada @aborgna-q