Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extract pytket parameters to input wires #661

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

aborgna-q
Copy link
Collaborator

Depends on #660
Closes #628

@aborgna-q aborgna-q requested a review from a team as a code owner October 14, 2024 14:34
@aborgna-q aborgna-q requested review from ss2165 and removed request for a team October 14, 2024 14:34
Base automatically changed from ab/update-hugr to main October 14, 2024 14:45
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.04%. Comparing base (d42842d) to head (af2c458).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
+ Coverage   82.00%   82.04%   +0.04%     
==========================================
  Files          50       50              
  Lines        6768     6784      +16     
  Branches     6768     6784      +16     
==========================================
+ Hits         5550     5566      +16     
  Misses        854      854              
  Partials      364      364              
Flag Coverage Δ
rust 82.04% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but maybe add a test of this new behavious?

@aborgna-q
Copy link
Collaborator Author

aborgna-q commented Oct 14, 2024

The PARAMETERIZED case in the pytket tests was already testing the roundtrip pytket -> tk2 -> pytket

const PARAMETERIZED: &str = r#"{
"phase": "0.0",
"bits": [],
"qubits": [["q", [0]], ["q", [1]]],
"commands": [
{"args":[["q",[0]]],"op":{"type":"H"}},
{"args":[["q",[1]],["q",[0]]],"op":{"type":"CX"}},
{"args":[["q",[0]]],"op":{"params":["(1.5707963267948966 / pi)"],"type":"Rz"}},
{"args": [["q", [0]]], "op": {"params": ["(3.141596 / pi)", "alpha", "(0.7853981633974483 / pi)"], "type": "TK1"}}
],
"created_qubits": [],
"discarded_qubits": [],
"implicit_permutation": [[["q", [0]], ["q", [0]]], [["q", [1]], ["q", [1]]]]
}"#;

I added another roundtrip test from tk2 to tk2 with some named and some unnamed params.

Copy link
Contributor

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@aborgna-q aborgna-q added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit f1d68bc Oct 15, 2024
16 checks passed
@aborgna-q aborgna-q deleted the ab/wire-decoded-params branch October 15, 2024 09:13
@aborgna-q aborgna-q mentioned this pull request Oct 15, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 15, 2024
## 🤖 New release
* `tket2`: 0.5.0 -> 0.6.0 (⚠️ API breaking changes)
* `tket2-hseries`: 0.5.0 -> 0.6.0 (✓ API compatible changes)

### ⚠️ `tket2` breaking changes

```
--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/inherent_method_missing.ron

Failed in:
  LexicographicCostFunction::default_cx, previously in file /private/var/folders/3j/ktpgz6yj0gn05q3x3d0qqndw0000gn/T/.tmpwozYGu/tket2/src/rewrite/strategy.rs:349

--- failure pub_module_level_const_missing: pub module-level const is missing ---

Description:
A public const is missing, renamed, or changed from const to static.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/pub_module_level_const_missing.ron

Failed in:
  SYM_OP_ID in file /private/var/folders/3j/ktpgz6yj0gn05q3x3d0qqndw0000gn/T/.tmpwozYGu/tket2/src/extension/sympy.rs:27
  SYM_EXPR_NAME in file /private/var/folders/3j/ktpgz6yj0gn05q3x3d0qqndw0000gn/T/.tmpwozYGu/tket2/src/extension/sympy.rs:24

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/struct_missing.ron

Failed in:
  struct tket2::extension::SYM_EXPR_T, previously in file /private/var/folders/3j/ktpgz6yj0gn05q3x3d0qqndw0000gn/T/.tmpwozYGu/tket2/src/extension/sympy.rs:140
```

<details><summary><i><b>Changelog</b></i></summary><p>

## `tket2`
<blockquote>

##
[0.6.0](tket2-v0.5.0...tket2-v0.6.0)
- 2024-10-15

### New Features

- *(badger)* `cx` and `rz` const functions and strategies for
`LexicographicCostFunction`
([#625](#625))
- Add `tket2.rotation.from_halfturns_unchecked` op
([#640](#640))
- [**breaking**] update to hugr 0.13.0
([#645](#645))
- Decode pytket op parameters
([#644](#644))
- re-export hugr crate ([#652](#652))
- Extract pytket parameters to input wires
([#661](#661))

### Refactor

- [**breaking**] Remove deprecated exports
([#662](#662))
</blockquote>

## `tket2-hseries`
<blockquote>

##
[0.4.0](tket2-hseries-v0.3.0...tket2-hseries-v0.4.0)
- 2024-09-16

### New Features

- [**breaking**] `HSeriesPass` lowers `Tk2Op`s into `HSeriesOp`s
([#602](#602))
- [**breaking**] simplify angle extension in to a half turns rotation
type ([#611](#611))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Co-authored-by: Agustín Borgna <[email protected]>
@hugrbot hugrbot mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect operation parameters as circuit inputs (+name symbol ops)
3 participants