Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(py): Support python 3.13 #653

Merged
merged 1 commit into from
Oct 11, 2024
Merged

chore(py): Support python 3.13 #653

merged 1 commit into from
Oct 11, 2024

Conversation

aborgna-q
Copy link
Collaborator

No description provided.

@aborgna-q aborgna-q requested a review from a team as a code owner October 11, 2024 14:45
@aborgna-q aborgna-q requested a review from ss2165 October 11, 2024 14:45
@aborgna-q aborgna-q added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit d8b5150 Oct 11, 2024
13 checks passed
@aborgna-q aborgna-q deleted the ab/python-313 branch October 11, 2024 14:51
aborgna-q added a commit that referenced this pull request Oct 14, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 14, 2024
This reverts commit d8b5150.

`tket2` depends on `pytket`, which does not currently publish wheels for
`python 3.13`.
We'll have to wait for them to update this package.
github-merge-queue bot pushed a commit that referenced this pull request Oct 14, 2024
#653 enabled support for python 3.13, but CI should have failed since
the `pytket` dependency does not publish wheels for 3.13.

This PR ensures uv doesn't fallback to a lower version when it
encounters unsupported dependencies.
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2024
Let's try #653 again.
The [latest `pytket`](https://github.com/CQCL/tket/releases/tag/1.34.0)
supports python `3.13`, so we can update here.

We now follow the
[general](https://iscinumpy.dev/post/bound-version-constraints/#pinning-the-python-version-is-special)
[recommendation](https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#python-requires)
against setting a hard python version bound in the `pyproject.toml`'s
`requires-python` field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants