Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: new CircuitMatch struct #55

Merged
merged 12 commits into from
Aug 29, 2023
Merged

feat!: new CircuitMatch struct #55

merged 12 commits into from
Aug 29, 2023

Conversation

lmondada
Copy link
Contributor

  • chore: update to portgraph v0.8
  • feat!: new CircuitMatch struct

@lmondada lmondada force-pushed the feature/convex branch 2 times, most recently from fb1085b to d3b9a1b Compare August 28, 2023 16:57
@lmondada lmondada marked this pull request as draft August 28, 2023 16:59
@lmondada lmondada force-pushed the feature/convex branch 3 times, most recently from aed8cf5 to 0e94dab Compare August 28, 2023 18:28
BREAKING CHANGE: `CircuitMatcher` no longer implements `PortMatcher`. `find_matches`
and `find_rooted_matches` now return `CircuitMatch`es.
@lmondada lmondada marked this pull request as ready for review August 28, 2023 18:35
Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Update hugr's fix-no-resource-validation to include CQCL/hugr#440 before merging this.

Cargo.toml Outdated Show resolved Hide resolved
pyrs/Cargo.toml Outdated Show resolved Hide resolved
src/portmatching/matcher.rs Outdated Show resolved Hide resolved
src/portmatching/matcher.rs Show resolved Hide resolved
src/portmatching/matcher.rs Outdated Show resolved Hide resolved
src/portmatching/matcher.rs Outdated Show resolved Hide resolved
src/portmatching/matcher.rs Outdated Show resolved Hide resolved
src/portmatching/pyo3.rs Outdated Show resolved Hide resolved
src/portmatching/pattern.rs Show resolved Hide resolved
Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/portmatching/pattern.rs Show resolved Hide resolved
@lmondada lmondada merged commit 991c9dd into main Aug 29, 2023
5 checks passed
@lmondada lmondada deleted the feature/convex branch August 29, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants