-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: new CircuitMatch struct #55
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lmondada
commented
Aug 28, 2023
- chore: update to portgraph v0.8
- feat!: new CircuitMatch struct
lmondada
force-pushed
the
feature/convex
branch
2 times, most recently
from
August 28, 2023 16:57
fb1085b
to
d3b9a1b
Compare
lmondada
force-pushed
the
feature/convex
branch
3 times, most recently
from
August 28, 2023 18:28
aed8cf5
to
0e94dab
Compare
BREAKING CHANGE: `CircuitMatcher` no longer implements `PortMatcher`. `find_matches` and `find_rooted_matches` now return `CircuitMatch`es.
lmondada
force-pushed
the
feature/convex
branch
from
August 28, 2023 18:30
0e94dab
to
8c32299
Compare
aborgna-q
reviewed
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Update hugr's fix-no-resource-validation
to include CQCL/hugr#440 before merging this.
Co-authored-by: Agustín Borgna <[email protected]>
Co-authored-by: Agustín Borgna <[email protected]>
Co-authored-by: Agustín Borgna <[email protected]>
Co-authored-by: Agustín Borgna <[email protected]>
# Conflicts: # pyrs/Cargo.toml
aborgna-q
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.